From: "Torsten Bögershausen" <tboegi@web.de>
To: "Junio C Hamano" <gitster@pobox.com>,
"Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3] t9001: avoid not portable '\n' with sed
Date: Tue, 10 Jun 2014 08:30:48 +0200 [thread overview]
Message-ID: <5396A618.5040306@web.de> (raw)
In-Reply-To: <xmqqk38pb95s.fsf@gitster.dls.corp.google.com>
On 06/10/2014 07:55 AM, Junio C Hamano wrote:
> Torsten Bögershausen <tboegi@web.de> writes:
>
>> t9001 used a '\n' in a sed expression to split one line into two lines,
>> but the usage of '\n' in the "replacement string" is not portable.
> This looks peculiarly familiar; don't I already have it queued?
Yes, V2 is queued and in pu,and only the commit msg is changed
between V2 and V3.
I think that V3 explains the difference between POSIX sed and
gnu sed much better, and does reflect all the comments from
the list, which otherwise may be lost.
And I suspect that not only the sed under Mac OS X does not
handle this very '\n' different from gnu sed, or in other words,
more platforms may not have a gnu sed and may need the fix.
next prev parent reply other threads:[~2014-06-10 6:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 4:07 [PATCH v3] t9001: avoid not portable '\n' with sed Torsten Bögershausen
2014-06-10 5:03 ` Eric Sunshine
2014-06-10 5:55 ` Junio C Hamano
2014-06-10 6:30 ` Torsten Bögershausen [this message]
2014-06-10 15:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5396A618.5040306@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.