From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuH38-0001uB-Lr for qemu-devel@nongnu.org; Tue, 10 Jun 2014 04:05:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuH32-00076u-Sl for qemu-devel@nongnu.org; Tue, 10 Jun 2014 04:04:54 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:58375 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuH32-00076i-Hk for qemu-devel@nongnu.org; Tue, 10 Jun 2014 04:04:48 -0400 Message-ID: <5396BC1B.3020703@kamp.de> Date: Tue, 10 Jun 2014 10:04:43 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1401485884-25500-1-git-send-email-pl@kamp.de> <20140603172714.GH3017@work-vm> <20140610073146.GJ27148@grmbl.mre> In-Reply-To: <20140610073146.GJ27148@grmbl.mre> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RESEND] migration: catch unknown flags in ram_load List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah , "Dr. David Alan Gilbert" Cc: pbonzini@redhat.com, quintela@redhat.com, qemu-stable@nongnu.org, qemu-devel@nongnu.org On 10.06.2014 09:31, Amit Shah wrote: > On (Tue) 03 Jun 2014 [18:27:15], Dr. David Alan Gilbert wrote: >> * Peter Lieven (pl@kamp.de) wrote: >>> if a saved vm has unknown flags in the memory data qemu >>> currently simply ignores this flag and continues which >>> yields in an unpredictable result. >>> >>> this patch catches all unknown flags and >>> aborts the loading of the vm. >> Yes, I think that's quite nice - the only thing I'd add which would help >> a little is an error_report() in the case where you have invalid flags >> to let you know that's the reason for the EINVAL. >> >> (Having spent the day tracking down migration bugs...) > Peter, can you please add these before we pick the patch up? On its way. Peter