From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34328)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1WuHix-0004Vz-3z
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 04:48:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1WuHir-0006b0-VF
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 04:48:07 -0400
Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:47477 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1WuHir-0006aW-KG
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 04:48:01 -0400
Message-ID: <5396C63C.6010302@kamp.de>
Date: Tue, 10 Jun 2014 10:47:56 +0200
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1402387463-17246-1-git-send-email-pl@kamp.de>
	<20140610084535.GB10960@grmbl.mre>
In-Reply-To: <20140610084535.GB10960@grmbl.mre>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCHv3] migration: catch unknown flags in
	ram_load
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: quintela@redhat.com, qemu-stable@nongnu.org, qemu-devel@nongnu.org, pbonzini@redhat.com, dgilbert@redhat.com

On 10.06.2014 10:45, Amit Shah wrote:
> On (Tue) 10 Jun 2014 [10:04:23], Peter Lieven wrote:
>> if a saved vm has unknown flags in the memory data qemu
>> currently simply ignores this flag and continues which
>> yields in an unpredictable result.
>>
>> this patch catches all unknown flags and
>> aborts the loading of the vm.
>>
>> CC: qemu-stable@nongnu.org
>> Signed-off-by: Peter Lieven <pl@kamp.de>
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
>
>> ---
>> v2->v3: - reworked last case in the if statement
>>          - added an error_report in case of an unknown flag [David]
> Thanks.  Would be nice to get an error_report() for the other error
> conditions, too.  It's not fun to learn migration has failed, w/o any
> clue of why or where.

Ok, will send v4.

Peter

>
> 		Amit


-- 

Mit freundlichen Grüßen

Peter Lieven

...........................................................

   KAMP Netzwerkdienste GmbH
   Vestische Str. 89-91 | 46117 Oberhausen
   Tel: +49 (0) 208.89 402-50 | Fax: +49 (0) 208.89 402-40
   pl@kamp.de | http://www.kamp.de

   Geschäftsführer: Heiner Lante | Michael Lante
   Amtsgericht Duisburg | HRB Nr. 12154
   USt-Id-Nr.: DE 120607556

...........................................................