From: Frederic Konrad <fred.konrad@greensocs.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>,
mark.burton@greensocs.com, qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
pbonzini@redhat.com, vilanova@ac.upc.edu
Subject: Re: [Qemu-devel] [RFC PATCH v3 02/13] migration: migrate icount fields.
Date: Tue, 10 Jun 2014 14:12:04 +0200 [thread overview]
Message-ID: <5396F614.1090001@greensocs.com> (raw)
In-Reply-To: <20140610062018.GF27148@grmbl.mre>
On 10/06/2014 08:20, Amit Shah wrote:
> On (Fri) 16 May 2014 [17:00:37], fred.konrad@greensocs.com wrote:
>> From: KONRAD Frederic <fred.konrad@greensocs.com>
>>
>> This fixes a bug where qemu_icount and qemu_icount_bias are not migrated.
>> It adds a subsection "timer/icount" to vmstate_timers so icount is migrated only
>> when needed.
>>
>> Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
>
>> +static bool icount_state_needed(void *opaque)
>> +{
>> + return (use_icount != 0);
>> +}
> You can just say 'return use_icount;' here instead.
>
> Amit
>
Hi,
Thanks for the review, I'll make this change.
Fred
next prev parent reply other threads:[~2014-06-10 12:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 15:00 [Qemu-devel] [RFC PATCH v3 00/13] Reverse execution fred.konrad
2014-05-16 15:00 ` [Qemu-devel] [RFC PATCH v3 01/13] icount: put icount variables into TimerState fred.konrad
2014-05-16 15:00 ` [Qemu-devel] [RFC PATCH v3 02/13] migration: migrate icount fields fred.konrad
2014-06-10 6:20 ` Amit Shah
2014-06-10 12:12 ` Frederic Konrad [this message]
2014-05-16 15:00 ` [Qemu-devel] [RFC PATCH v3 03/13] migration: make qemu_savevm_state public fred.konrad
2014-06-10 6:20 ` Amit Shah
2014-05-16 15:00 ` [Qemu-devel] [RFC PATCH v3 04/13] icount: introduce icount timer fred.konrad
2014-05-16 15:00 ` [Qemu-devel] [RFC PATCH v3 05/13] icount: check for icount clock deadline when cpu loop exits fred.konrad
2014-05-16 15:00 ` [Qemu-devel] [RFC PATCH v3 06/13] icount: make icount extra computed on icount clock as well fred.konrad
2014-05-16 15:00 ` [Qemu-devel] [RFC PATCH v3 07/13] timer: add cpu_icount_to_ns function fred.konrad
2014-05-16 15:00 ` [Qemu-devel] [RFC PATCH v3 08/13] trace-events: add reverse-execution events fred.konrad
2014-05-16 15:00 ` [Qemu-devel] [RFC PATCH v3 09/13] introduce reverse execution mechanism fred.konrad
2014-05-16 15:00 ` [Qemu-devel] [RFC PATCH v3 10/13] gdbstub: allow reverse execution in gdb stub fred.konrad
2014-05-16 15:00 ` [Qemu-devel] [RFC PATCH v3 11/13] cpu-exec: trigger a debug request when rexec stops fred.konrad
2014-05-16 15:00 ` [Qemu-devel] [RFC PATCH v3 12/13] cexe: synchronize icount on the next event fred.konrad
2014-05-16 15:00 ` [Qemu-devel] [RFC PATCH v3 13/13] cexe: allow to enable reverse execution fred.konrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5396F614.1090001@greensocs.com \
--to=fred.konrad@greensocs.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mark.burton@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.