From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60066)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1WuKuS-0000U4-Sx
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 08:12:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1WuKuN-0005cv-Ej
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 08:12:12 -0400
Received: from [2001:41d0:8:2b42::1] (port=49194 helo=greensocs.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1WuKuN-0005cY-8s
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 08:12:07 -0400
Message-ID: <5396F614.1090001@greensocs.com>
Date: Tue, 10 Jun 2014 14:12:04 +0200
From: Frederic Konrad <fred.konrad@greensocs.com>
MIME-Version: 1.0
References: <1400252448-13347-1-git-send-email-fred.konrad@greensocs.com>	<1400252448-13347-3-git-send-email-fred.konrad@greensocs.com>
	<20140610062018.GF27148@grmbl.mre>
In-Reply-To: <20140610062018.GF27148@grmbl.mre>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v3 02/13] migration: migrate icount
	fields.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>, mark.burton@greensocs.com, qemu-devel@nongnu.org, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, pbonzini@redhat.com, vilanova@ac.upc.edu

On 10/06/2014 08:20, Amit Shah wrote:
> On (Fri) 16 May 2014 [17:00:37], fred.konrad@greensocs.com wrote:
>> From: KONRAD Frederic <fred.konrad@greensocs.com>
>>
>> This fixes a bug where qemu_icount and qemu_icount_bias are not migrated.
>> It adds a subsection "timer/icount" to vmstate_timers so icount is migrated only
>> when needed.
>>
>> Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
>
>> +static bool icount_state_needed(void *opaque)
>> +{
>> +    return (use_icount != 0);
>> +}
> You can just say 'return use_icount;' here instead.
>
> 		Amit
>
Hi,

Thanks for the review, I'll make this change.

Fred