Re: [Qemu-devel] [PATCH v10-fix 15/18] Add the vhost-user netdev backend to the command line

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

On 06/10/2014 07:03 AM, Michael S. Tsirkin wrote:
> On Tue, Jun 10, 2014 at 06:11:16AM -0600, Eric Blake wrote:
>> On 06/10/2014 04:02 AM, Nikolay Nikolaev wrote:
>>> The supplied chardev id will be inspected for supported options. Only
>>> a socket backend, with a set path (i.e. a Unix socket) and optionally
>>> the server parameter set, will be allowed. Other options (nowait, telnet)
>>> will make the chardev unusable and the netdev will not be initialised.
>>>

>>> +##
>>> +{ 'type': 'NetdevVhostUserOptions',
>>> +  'data': {
>>> +    'chardev':        'str',
>>> +    '*vhost-force':    'bool' } }
>>
>> [1]...and here you call it vhost-force...
>>
> 
> Should be vhostforce, consistent with tap.

Oh, good point - no need to make the user have to guess which of two
spellings to use.  Sorry for not noticing that earlier when I was
bikeshedding in my request to add a '-'.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]