From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: return meaningful error codes from mmc_select_hwpart
Date: Tue, 10 Jun 2014 10:00:05 -0600 [thread overview]
Message-ID: <53972B85.2030308@wwwdotorg.org> (raw)
In-Reply-To: <B7E133A1-B561-40E1-8026-9A498D9FC6FA@antoniou-consulting.com>
On 06/02/2014 12:18 AM, Pantelis Antoniou wrote:
> On May 23, 2014, at 9:47 PM, Stephen Warren wrote:
>> Rather than just returning -1 everywhere, try to return something
>> meaningful from mmc_select_hwpart(). Note that most other MMC functions
>> don't do this, including functions called from mmc_select_hwpart(), so
>> I'm not sure how effective this will be. Still, it's one less place with
>> hard-coded -1.
...
> This does indeed look good.
...
> Acked-by: Pantelis Antoniou <panto@antoniou-consulting.com>
Are you intending to apply this patch, or were you expecting someone
else to?
next prev parent reply other threads:[~2014-06-10 16:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 18:47 [U-Boot] [PATCH] mmc: return meaningful error codes from mmc_select_hwpart Stephen Warren
2014-05-30 21:11 ` Stephen Warren
2014-06-02 6:18 ` Pantelis Antoniou
2014-06-10 16:00 ` Stephen Warren [this message]
2014-06-10 16:01 ` Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53972B85.2030308@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.