From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Thomas Monjalon
<thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>,
dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v3] mk: allow updates to build config on make install
Date: Tue, 10 Jun 2014 18:02:44 +0200 [thread overview]
Message-ID: <53972C24.1040305@6wind.com> (raw)
In-Reply-To: <1402408293-19426-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Hi Thomas,
On 06/10/2014 03:51 PM, Thomas Monjalon wrote:
> + if [ -f $(BUILD_DIR)/$*/.config.orig ] ; then \
> + tmp_build=/tmp/dpdk-$*-$$$$; \
> + $(MAKE) config T=$* O=$$(tmp_build); \
> + if ! cmp -s $(BUILD_DIR)/$*/.config.orig $$(tmp_build)/.config ; then \
> + echo "Conflict: local config and template config have both changed"; \
> + exit 1; \
I missed it the first time, but what do you think about using
$(BUILD_DIR)/$*/.config.tmp instead of /tmp/dpdk-$*-$$ ?
I think using /tmp should be avoided when possible as it is a
shared folder.
Regards,
Olivier
next prev parent reply other threads:[~2014-06-10 16:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 10:22 [PATCH] mk: allow updates to build config on make install Bruce Richardson
[not found] ` <1400062955-27338-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-05-14 10:33 ` Thomas Monjalon
2014-05-14 10:51 ` Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B01AA196E4-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-05-14 11:55 ` Thomas Monjalon
2014-05-14 12:33 ` Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B01AA19761-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-05-14 12:54 ` Thomas Monjalon
2014-05-14 12:57 ` Richardson, Bruce
2014-05-14 15:55 ` [PATCH v2] " Bruce Richardson
[not found] ` <1400082910-16804-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-05-20 11:37 ` Olivier MATZ
[not found] ` <537B3E91.4030400-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-06-10 13:51 ` [PATCH v3] " Thomas Monjalon
[not found] ` <1402408293-19426-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-06-10 16:02 ` Olivier MATZ [this message]
[not found] ` <53972C24.1040305-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-06-10 16:29 ` Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B01AA3475A-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-10 16:38 ` [PATCH v4] " Thomas Monjalon
[not found] ` <1402418283-21950-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-06-10 18:43 ` Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B01AA34876-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-11 9:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53972C24.1040305@6wind.com \
--to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.