From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH] ARM: qcom: select GSBI from mach kconfig Date: Tue, 10 Jun 2014 10:31:33 -0700 Message-ID: <539740F5.9030204@codeaurora.org> References: <1402398980-24664-1-git-send-email-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:54851 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752460AbaFJRbh (ORCPT ); Tue, 10 Jun 2014 13:31:37 -0400 In-Reply-To: <1402398980-24664-1-git-send-email-srinivas.kandagatla@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Srinivas Kandagatla Cc: Kumar Gala , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King , David Brown On 06/10/14 04:16, Srinivas Kandagatla wrote: > This patch adds GSBI selection automatically from mach kconfig, As GSBI > seems to be the very basic SOC specific driver and serial driver depends on it. > I think this option should be selected via mach kconfig rather than adding > it to any defconfig. > > Without this patch multi_v7_defconfig can not show up console on > IFC6410. > > Signed-off-by: Srinivas Kandagatla > No, we should be getting rid of selects, not adding more. Just put this in the multi_v7_defconfig. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Tue, 10 Jun 2014 10:31:33 -0700 Subject: [PATCH] ARM: qcom: select GSBI from mach kconfig In-Reply-To: <1402398980-24664-1-git-send-email-srinivas.kandagatla@linaro.org> References: <1402398980-24664-1-git-send-email-srinivas.kandagatla@linaro.org> Message-ID: <539740F5.9030204@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/10/14 04:16, Srinivas Kandagatla wrote: > This patch adds GSBI selection automatically from mach kconfig, As GSBI > seems to be the very basic SOC specific driver and serial driver depends on it. > I think this option should be selected via mach kconfig rather than adding > it to any defconfig. > > Without this patch multi_v7_defconfig can not show up console on > IFC6410. > > Signed-off-by: Srinivas Kandagatla > No, we should be getting rid of selects, not adding more. Just put this in the multi_v7_defconfig. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation