From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH 5/6] libxl: allow a generation ID to be specified at domain creation Date: Tue, 10 Jun 2014 18:59:23 +0100 Message-ID: <5397477B.80801@citrix.com> References: <1401801340-6196-1-git-send-email-david.vrabel@citrix.com> <1401801340-6196-6-git-send-email-david.vrabel@citrix.com> <1402398065.1250.36.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WuQKW-000832-24 for xen-devel@lists.xenproject.org; Tue, 10 Jun 2014 17:59:28 +0000 In-Reply-To: <1402398065.1250.36.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 10/06/14 12:01, Ian Campbell wrote: > On Tue, 2014-06-03 at 14:15 +0100, David Vrabel wrote: > Should we consider calling the API field name something more specific, > like "ms_vgid"? I'm thinking of the case where some other OS vendor > reinvents the wheel. (I don't care about the internals, just the API). generation_id matches the platform/generation-id xenstore key so I would keep the libxl field name as-is. > Do you not need to worry about endianess when memcpy'ing out of a uuid? No. The conversion of uuid to the two 64-bit integers is arbitrary, it need only be consistent. The integers in guest memory are in native endianness. David