From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuRDX-0006XR-Ok for qemu-devel@nongnu.org; Tue, 10 Jun 2014 14:56:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuRDS-0007FW-QQ for qemu-devel@nongnu.org; Tue, 10 Jun 2014 14:56:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53969) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuRDS-0007EZ-G1 for qemu-devel@nongnu.org; Tue, 10 Jun 2014 14:56:14 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5AIuDPU003927 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 10 Jun 2014 14:56:13 -0400 Message-ID: <539754CC.6070701@redhat.com> Date: Tue, 10 Jun 2014 12:56:12 -0600 From: Eric Blake MIME-Version: 1.0 References: <1402282583-19707-1-git-send-email-famz@redhat.com> <1402282583-19707-3-git-send-email-famz@redhat.com> In-Reply-To: <1402282583-19707-3-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CEjNDcXfQ5AMfmDeK24DcBH2brJwVsSpk" Subject: Re: [Qemu-devel] [PATCH v2 2/4] mirror: Go through ready -> complete process for 0 len image List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , jcody@redhat.com, Stefan Hajnoczi , Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CEjNDcXfQ5AMfmDeK24DcBH2brJwVsSpk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/08/2014 08:56 PM, Fam Zheng wrote: > When mirroring or active committing a zero length image, BLOCK_JOB_READ= Y > is not reported now, instead the job completes because we short circuit= > the mirror job loop. >=20 > This is inconsistent with non-zero length images, and only confuses > management software. >=20 > Let's do the same thing when seeing a 0-length image: report ready > immediately; wait for block-job-cancel or block-job-complete; clear the= > cancel flag as existing non-zero image synced case (cancelled after > ready); then jump to the exit. >=20 > Reported-by: Eric Blake > Signed-off-by: Fam Zheng > --- > block/mirror.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CEjNDcXfQ5AMfmDeK24DcBH2brJwVsSpk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTl1TMAAoJEKeha0olJ0Nq4HQH/0rcrKoPt7Whjm+ohcufNh83 wdWATBtTavBSrTHx3wAUXAe0dT8IuLfecHDxOaAN3hTlGuft1xuO+kwORO1hfc57 4Dc9NMppPWbmpbOtxFGQTPGOs6CrckG6lPL4A08fKjPeIPJWHgNYS+m7uV466T+u MO6DYMqvhqHVlLHr8M38kKp7224Fwn/rt2EEDtqmmkaRLNv76ljPyFPPxJU41ZQG RFej0frQ+2wFr8iEutgCURgx2ab5snBams3F5lVN4LFupkjfjuP8xZS7SbFFslNo s2UTFjFgaYJLOwemXpljYGE5CwcBw+0g3CfJKfoHQOZy8a3CFnja8SEHtkU99eM= =1xMR -----END PGP SIGNATURE----- --CEjNDcXfQ5AMfmDeK24DcBH2brJwVsSpk--