Re: [meta-raspberrypi][PATCH 1/2] userland: Add '--no-as-needed' linker flag to ensure all specified shared libraries are linked against applications (e.g. raspivid)

[Alex J Lennon <ajlennon@dynamicdevices.co.uk>]

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]


On 10/06/2014 19:22, Andrei Gherzan wrote:
>
>
> On Mon, Jun 2, 2014 at 1:58 PM, Alex J Lennon
> <ajlennon@dynamicdevices.co.uk <mailto:ajlennon@dynamicdevices.co.uk>>
> wrote:
>
>     libmmal_vc_client.so makes use of __attribute__(constructor) to
>     ensure that supplier components (e.g. camera) are loaded when the
>     static library is loaded.
>
>
> There shouldn't be more than 78 characters per line. I did this change
> for this patch (the other you already submited). More info:
> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Understood - thanks Andrei, I'll try to bear that in mind.

Perhaps you'd be open to the idea of a patch to add these requirements
into the meta-raspberrypi README in-between 5A/5B.

I believe it would help contributors like myself, who are new to the
process requirements, to understand how to put a patch together
correctly, as well as where to sent it.

Cheers,

Alex

[-- Attachment #2: Type: text/html, Size: 2257 bytes --]