From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 48FC0E00BE1; Tue, 10 Jun 2014 16:28:28 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=HTML_MESSAGE autolearn=ham version=3.3.1 X-Spam-HAM-Report: * 0.0 HTML_MESSAGE BODY: HTML included in message Received: from www.dynamicdevices.co.uk (www.dynamicdevices.co.uk [89.200.136.37]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 98724E00B83 for ; Tue, 10 Jun 2014 16:28:23 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by www.dynamicdevices.co.uk (Postfix) with ESMTP id A560427E039; Tue, 10 Jun 2014 23:28:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at lennoab2.miniserver.com Received: from www.dynamicdevices.co.uk ([127.0.0.1]) by localhost (www.dynamicdevices.co.uk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JecEP7yhcoCq; Tue, 10 Jun 2014 23:27:56 +0000 (UTC) Received: from [127.0.0.1] (cpc32-live22-2-0-cust59.17-2.cable.virginm.net [82.36.253.60]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by www.dynamicdevices.co.uk (Postfix) with ESMTPSA id 75E6E27E036; Tue, 10 Jun 2014 23:27:56 +0000 (UTC) Message-ID: <5397947A.6050605@dynamicdevices.co.uk> Date: Wed, 11 Jun 2014 00:27:54 +0100 From: Alex J Lennon User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Andrei Gherzan References: In-Reply-To: X-Enigmail-Version: 1.6 Cc: Yocto Project Subject: Re: [meta-raspberrypi][PATCH 1/1] gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio. X-BeenThere: yocto@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Discussion of all things Yocto Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2014 23:28:28 -0000 Content-Type: multipart/alternative; boundary="------------040101080205000400040501" --------------040101080205000400040501 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/06/2014 19:59, Andrei Gherzan wrote: > Hello Alex. > > On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon > > > wrote: > > This changes the build slightly as there are some #ifdefs in there > for Raspberry Pi. > > Also the codec configuration file used by gstreamer1.0-omx codecs, > /etc/xdg/gstomx.conf, is set correctly to > core-name=/usr/lib/libopenmaxil.so > > Change-Id: I2352ecabfd053717d9ccd2d22422e7d4b7588ce4 > Signed-off-by: Alex J Lennon > > --- > recipes-multimedia/gstreamer/gstreamer1.0-omx.inc | 2 ++ > recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 + > > > I was thinking we we really need two files for this... I know that > yocto has an inc too. But i don't know if that really makes sense for > one line. What do you think? > I came across Yocto best practice here. This is more or less why I provided a patch for consideration into Poky on this earlier today. It would help me, and I suspect other newbies, to have best practice expectations on how to put patches together somewhere up front, say in the README. "Do not merge .inc / .bb files" https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating Cheers, Alex --------------040101080205000400040501 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
On 10/06/2014 19:59, Andrei Gherzan wrote:
Hello Alex.

On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon <ajlennon@dynamicdevices.co.uk> wrote:
This changes the build slightly as there are some #ifdefs in there for Raspberry Pi.

Also the codec configuration file used by gstreamer1.0-omx codecs, /etc/xdg/gstomx.conf,  is set correctly to core-name=/usr/lib/libopenmaxil.so

Change-Id: I2352ecabfd053717d9ccd2d22422e7d4b7588ce4
Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
---
 recipes-multimedia/gstreamer/gstreamer1.0-omx.inc            | 2 ++
 recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 +

I was thinking we we really need two files for this... I know that yocto has an inc too. But i don't know if that really makes sense for one line. What do you think? 
 

I came across Yocto best practice here. This is more or less why I provided a patch for consideration into Poky on this earlier today. It would help me, and I suspect other newbies, to have best practice expectations on how to put patches together somewhere up front, say in the README.

"Do not merge .inc / .bb files"

https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating

Cheers,

Alex

--------------040101080205000400040501--