From: Or Gerlitz <ogerlitz@mellanox.com>
To: Doug Ledford <dledford@redhat.com>, <netdev@vger.kernel.org>
Cc: Rony Efraim <ronye@mellanox.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net/core: Add VF link state control policy
Date: Wed, 11 Jun 2014 11:01:10 +0300 [thread overview]
Message-ID: <53980CC6.1080303@mellanox.com> (raw)
In-Reply-To: <d040256cbe494908726bb1d05612f69cee4ff040.1402430365.git.dledford@redhat.com>
On 10/06/2014 22:59, Doug Ledford wrote:
> Commit 1d8faf48c7 added VF link state control to the netlink VF nested
> structure, but failed to add a proper entry for the new structure into
> the VF policy table. Add the missing entry so the table and the actual
> data copied into the netlink nested struct are in sync.
>
> Signed-off-by: Doug Ledford <dledford@redhat.com>
> ---
> net/core/rtnetlink.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index 2d8d8fcfa06..cdccf028171 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -1208,6 +1208,8 @@ static const struct nla_policy ifla_vf_policy[IFLA_VF_MAX+1] = {
> .len = sizeof(struct ifla_vf_tx_rate) },
> [IFLA_VF_SPOOFCHK] = { .type = NLA_BINARY,
> .len = sizeof(struct ifla_vf_spoofchk) },
> + [IFLA_VF_LINK_STATE] = { .type = NLA_BINARY,
> + .len = sizeof(struct ifla_vf_link_state) },
> };
nice catch, thanks. Note that currently this table isn't in use, so
fixing here would actually serve to avoid future bugs, but this is of
course OK too.
Rony and Or.
next prev parent reply other threads:[~2014-06-11 8:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 19:59 [PATCH] net/core: Add VF link state control policy Doug Ledford
2014-06-10 20:09 ` Sergei Shtylyov
2014-06-10 20:12 ` Doug Ledford
2014-06-11 3:47 ` David Miller
2014-06-11 8:01 ` Or Gerlitz [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-11 14:38 Doug Ledford
2014-06-11 22:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53980CC6.1080303@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ronye@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.