On 11/06/2014 08:47, Andrei Gherzan wrote:



On Wed, Jun 11, 2014 at 2:27 AM, Alex J Lennon <ajlennon@dynamicdevices.co.uk> wrote:

On 10/06/2014 19:59, Andrei Gherzan wrote:
Hello Alex.

On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon <ajlennon@dynamicdevices.co.uk> wrote:
This changes the build slightly as there are some #ifdefs in there for Raspberry Pi.

Also the codec configuration file used by gstreamer1.0-omx codecs, /etc/xdg/gstomx.conf,  is set correctly to core-name=/usr/lib/libopenmaxil.so

Change-Id: I2352ecabfd053717d9ccd2d22422e7d4b7588ce4
Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
---
 recipes-multimedia/gstreamer/gstreamer1.0-omx.inc            | 2 ++
 recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 +

I was thinking we we really need two files for this... I know that yocto has an inc too. But i don't know if that really makes sense for one line. What do you think? 
 

I came across Yocto best practice here. This is more or less why I provided a patch for consideration into Poky on this earlier today. It would help me, and I suspect other newbies, to have best practice expectations on how to put patches together somewhere up front, say in the README.

"Do not merge .inc / .bb files"

https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating

I understand. But I think that this is the case only for bb files. We are talking here about a bbappend in which case this would be pretty useless. Nobody reuses an inc for a bbappend - never seen something like that. 

e.g. I have gstreamer1.0-omx_git.bbappend here which reuses the .inc file. I didn't contribute it as for some reason the git build breaks and I need to look at why this is