diff for duplicates of <539812DB.5080903@bfs.de> diff --git a/a/1.txt b/N1/1.txt index c2ff02c..0986837 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -22,7 +22,7 @@ Am 11.06.2014 10:12, schrieb Dan Carpenter: >>> - return -ENOMEM; >>> + return 0; >>> ->>> if (strcmp(trigger_name, name) = 0) { +>>> if (strcmp(trigger_name, name) == 0) { >>> value = triggers[i].value; >> >> @@ -38,7 +38,7 @@ i as looking at at91_adc_configure_trigger() may it has changed lately 364 value = at91_adc_get_trigger_value_by_name(idev, 365 st->trigger_list, 366 idev->trig->name); -367 if (value = 0) +367 if (value == 0) 368 return -EINVAL; >> perhaps it is better to change the return value to int. diff --git a/a/content_digest b/N1/content_digest index b015851..a2c16e8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020140611081220.GP5500@mwanda\0" "From\0walter harms <wharms@bfs.de>\0" "Subject\0Re: [patch] iio: adc: at91: signedness bug in at91_adc_get_trigger_value_by_name()\0" - "Date\0Wed, 11 Jun 2014 08:27:07 +0000\0" + "Date\0Wed, 11 Jun 2014 10:27:07 +0200\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Cc\0Jonathan Cameron <jic23@kernel.org>" Grant Likely <grant.likely@linaro.org> @@ -44,7 +44,7 @@ ">>> -\t\t\treturn -ENOMEM;\n" ">>> +\t\t\treturn 0;\n" ">>> \n" - ">>> \t\tif (strcmp(trigger_name, name) = 0) {\n" + ">>> \t\tif (strcmp(trigger_name, name) == 0) {\n" ">>> \t\t\tvalue = triggers[i].value;\n" ">>\n" ">>\n" @@ -60,7 +60,7 @@ "364 value = at91_adc_get_trigger_value_by_name(idev,\n" "365 st->trigger_list,\n" "366 idev->trig->name);\n" - "367 if (value = 0)\n" + "367 if (value == 0)\n" "368 return -EINVAL;\n" "\n" ">> perhaps it is better to change the return value to int.\n" @@ -84,4 +84,4 @@ "> \n" > -babe3bc5c7653a23ae23e045f4ee1b2f5c34500e5fb9444bd7ba96ff78efd72f +ae59a54b69c7a254bd25dd4253a3d7ff47bf54efc253f67df3aa9ad9ac921ac7
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.