From: Domen Puncer <domen.puncer@samsung.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: "netfilter-devel@vger.kernel.org" <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH iptables] libxtables: fix getaddrinfo return value usage
Date: Wed, 11 Jun 2014 10:48:19 +0100 [thread overview]
Message-ID: <539825E3.6020000@samsung.com> (raw)
In-Reply-To: <20140611093758.GA5427@localhost>
On 11/06/14 10:37, Pablo Neira Ayuso wrote:
> On Tue, Jun 10, 2014 at 02:29:49PM +0100, Domen Puncer wrote:
>> getaddrinfo return value on error can also be positive.
>
> At quick glance, all EAI_* that I see are negative.
You don't see all of them :-)
On Android they're positive, e.g.:
android-ndk-r9d/platforms/android-19/arch-arm/usr/include/netdb.h
147 #define EAI_NONAME 8 /* hostname nor servname provided,
or not known */
And as a plus, it's not bad to conform to specs.
>
> What problem are you experience? What case are you trying to catch?
>
> Thanks.
>
next prev parent reply other threads:[~2014-06-11 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 13:29 [PATCH iptables] libxtables: fix getaddrinfo return value usage Domen Puncer
2014-06-11 9:37 ` Pablo Neira Ayuso
2014-06-11 9:48 ` Domen Puncer [this message]
2014-06-11 17:55 ` Pablo Neira Ayuso
2014-06-12 7:01 ` Domen Puncer
2014-06-16 9:48 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539825E3.6020000@samsung.com \
--to=domen.puncer@samsung.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.