From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH 2/2 v3] ARM: DTS: move "cs-gpio" from "controller-data" to under spi node Date: Wed, 11 Jun 2014 13:21:35 +0200 Message-ID: <53983BBF.4070408@collabora.co.uk> References: <1402468318-7342-1-git-send-email-ch.naveen@samsung.com> <1402468318-7342-2-git-send-email-ch.naveen@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from bhuna.collabora.co.uk ([93.93.135.160]:51209 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754968AbaFKLVm (ORCPT ); Wed, 11 Jun 2014 07:21:42 -0400 In-Reply-To: <1402468318-7342-2-git-send-email-ch.naveen@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Naveen Krishna Chatradhi , linux-arm-kernel@lists.infradead.org, spi-devel-general@lists.sourceforge.net, linux-samsung-soc@vger.kernel.org Cc: naveenkrishna.ch@gmail.com, broonie@kernel.org, grant.likely@secretlab.ca, jaswinder.singh@linaro.org, kgene.kim@samsung.com, cpgs@samsung.com, devicetree@vger.kernel.org, Doug Anderson , Tomasz Figa Hello Naveen, On 06/11/2014 08:31 AM, Naveen Krishna Chatradhi wrote: > This patch moves the "cs-gpio" field from "controller-data" child > node to under the spi device node. > Your patch looks good to me but I think that the commit message is inaccurate. It does not move the cs-gpio property to the top SPI dev node but it replaces the cs-gpio from controller-data as was specified in the old binding and use the standard cs-gpios property expected by the SPI core as is defined in the new binding. Having a proper commit message is important since out-of-tree DTS can use this commit as a reference on how to fix their FDT in case this change broke their platforms. > Respective changes are preposed to spi-s3c64xx.c driver. > > Signed-off-by: Naveen Krishna Chatradhi > Acked-by: Rob Herring > Cc: Javier Martinez Canillas > Cc: Doug Anderson > Cc: Tomasz Figa > --- > Changes since v2: > None > > arch/arm/boot/dts/exynos4210-smdkv310.dts | 2 +- > arch/arm/boot/dts/exynos4412-trats2.dts | 2 +- > arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4210-smdkv310.dts b/arch/arm/boot/dts/exynos4210-smdkv310.dts > index 636d166..9191491 100644 > --- a/arch/arm/boot/dts/exynos4210-smdkv310.dts > +++ b/arch/arm/boot/dts/exynos4210-smdkv310.dts > @@ -169,6 +169,7 @@ > > spi_2: spi@13940000 { > status = "okay"; > + cs-gpios = <&gpc1 2 0>; > > w25x80@0 { > #address-cells = <1>; > @@ -178,7 +179,6 @@ > spi-max-frequency = <1000000>; > > controller-data { > - cs-gpio = <&gpc1 2 0>; > samsung,spi-feedback-delay = <0>; > }; > > diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts > index 8a558b7..204b0de 100644 > --- a/arch/arm/boot/dts/exynos4412-trats2.dts > +++ b/arch/arm/boot/dts/exynos4412-trats2.dts > @@ -512,6 +512,7 @@ > spi_1: spi@13930000 { > pinctrl-names = "default"; > pinctrl-0 = <&spi1_bus>; > + cs-gpios = <&gpb 5 0>; > status = "okay"; > > s5c73m3_spi: s5c73m3 { > @@ -519,7 +520,6 @@ > spi-max-frequency = <50000000>; > reg = <0>; > controller-data { > - cs-gpio = <&gpb 5 0>; > samsung,spi-feedback-delay = <2>; > }; > }; > diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts > index a794a70..0c6433a 100644 > --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts > +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts > @@ -316,6 +316,7 @@ > }; > > spi_1: spi@12d30000 { > + cs-gpios = <&gpa2 5 0>; > status = "okay"; > > w25q80bw@0 { > @@ -326,7 +327,6 @@ > spi-max-frequency = <1000000>; > > controller-data { > - cs-gpio = <&gpa2 5 0>; > samsung,spi-feedback-delay = <0>; > }; > > Best regards, Javier From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier.martinez@collabora.co.uk (Javier Martinez Canillas) Date: Wed, 11 Jun 2014 13:21:35 +0200 Subject: [PATCH 2/2 v3] ARM: DTS: move "cs-gpio" from "controller-data" to under spi node In-Reply-To: <1402468318-7342-2-git-send-email-ch.naveen@samsung.com> References: <1402468318-7342-1-git-send-email-ch.naveen@samsung.com> <1402468318-7342-2-git-send-email-ch.naveen@samsung.com> Message-ID: <53983BBF.4070408@collabora.co.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Naveen, On 06/11/2014 08:31 AM, Naveen Krishna Chatradhi wrote: > This patch moves the "cs-gpio" field from "controller-data" child > node to under the spi device node. > Your patch looks good to me but I think that the commit message is inaccurate. It does not move the cs-gpio property to the top SPI dev node but it replaces the cs-gpio from controller-data as was specified in the old binding and use the standard cs-gpios property expected by the SPI core as is defined in the new binding. Having a proper commit message is important since out-of-tree DTS can use this commit as a reference on how to fix their FDT in case this change broke their platforms. > Respective changes are preposed to spi-s3c64xx.c driver. > > Signed-off-by: Naveen Krishna Chatradhi > Acked-by: Rob Herring > Cc: Javier Martinez Canillas > Cc: Doug Anderson > Cc: Tomasz Figa > --- > Changes since v2: > None > > arch/arm/boot/dts/exynos4210-smdkv310.dts | 2 +- > arch/arm/boot/dts/exynos4412-trats2.dts | 2 +- > arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4210-smdkv310.dts b/arch/arm/boot/dts/exynos4210-smdkv310.dts > index 636d166..9191491 100644 > --- a/arch/arm/boot/dts/exynos4210-smdkv310.dts > +++ b/arch/arm/boot/dts/exynos4210-smdkv310.dts > @@ -169,6 +169,7 @@ > > spi_2: spi at 13940000 { > status = "okay"; > + cs-gpios = <&gpc1 2 0>; > > w25x80 at 0 { > #address-cells = <1>; > @@ -178,7 +179,6 @@ > spi-max-frequency = <1000000>; > > controller-data { > - cs-gpio = <&gpc1 2 0>; > samsung,spi-feedback-delay = <0>; > }; > > diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts > index 8a558b7..204b0de 100644 > --- a/arch/arm/boot/dts/exynos4412-trats2.dts > +++ b/arch/arm/boot/dts/exynos4412-trats2.dts > @@ -512,6 +512,7 @@ > spi_1: spi at 13930000 { > pinctrl-names = "default"; > pinctrl-0 = <&spi1_bus>; > + cs-gpios = <&gpb 5 0>; > status = "okay"; > > s5c73m3_spi: s5c73m3 { > @@ -519,7 +520,6 @@ > spi-max-frequency = <50000000>; > reg = <0>; > controller-data { > - cs-gpio = <&gpb 5 0>; > samsung,spi-feedback-delay = <2>; > }; > }; > diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts > index a794a70..0c6433a 100644 > --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts > +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts > @@ -316,6 +316,7 @@ > }; > > spi_1: spi at 12d30000 { > + cs-gpios = <&gpa2 5 0>; > status = "okay"; > > w25q80bw at 0 { > @@ -326,7 +327,6 @@ > spi-max-frequency = <1000000>; > > controller-data { > - cs-gpio = <&gpa2 5 0>; > samsung,spi-feedback-delay = <0>; > }; > > Best regards, Javier