From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wuj7s-0003cW-5W for qemu-devel@nongnu.org; Wed, 11 Jun 2014 10:03:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wuj7m-0006T7-0C for qemu-devel@nongnu.org; Wed, 11 Jun 2014 10:03:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wuj7l-0006T1-On for qemu-devel@nongnu.org; Wed, 11 Jun 2014 10:03:33 -0400 Message-ID: <539861B1.8020106@redhat.com> Date: Wed, 11 Jun 2014 16:03:29 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1402489176-19738-1-git-send-email-pbonzini@redhat.com> <1402489176-19738-5-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 04/13] qom: delete properties before calling instance_finalize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: "qemu-devel@nongnu.org Developers" , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Il 11/06/2014 15:42, Peter Crosthwaite ha scritto: >> > >> > - object_deinit(obj, ti); >> > object_property_del_all(obj); >> > + object_deinit(obj, ti); > Does this means you lose access to your own properties before calling > your own finalisation? I guess its a non-issue if all clients just use > private fields directly, but it seems weird you cant use your own > getter at the end because it's dissappeared on you already. It is just as weird that a property's finalizer cannot do its work because it needs something that instance_finalize has already freed. :) This is important with the previous patch, that calls arbitrary code of children objects at finalization time. Paolo