From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: [PATCH] ARM: Exynos : Fix build error with thumb2 Date: Thu, 12 Jun 2014 00:13:53 +0900 Message-ID: <53987231.6080200@samsung.com> References: <1401119625-11309-1-git-send-email-santosh.shukla@linaro.org> <20140602101023.GB3855@e103592.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pb0-f45.google.com ([209.85.160.45]:55363 "EHLO mail-pb0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049AbaFKPOE (ORCPT ); Wed, 11 Jun 2014 11:14:04 -0400 Received: by mail-pb0-f45.google.com with SMTP id um1so7581447pbc.32 for ; Wed, 11 Jun 2014 08:14:03 -0700 (PDT) In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Santosh Shukla Cc: Dave Martin , Kukjin Kim , Arnd Bergmann , linux@arm.linux.org.uk, Catalin Marinas , linux-samsung-soc , Viresh Kumar , "t.figa" , linaro-kernel , Thomas Abraham , linux-arm-kernel@lists.infradead.org On 06/04/14 17:07, Santosh Shukla wrote: > On 2 June 2014 15:40, Dave Martin wrote: >> On Mon, May 26, 2014 at 09:23:45PM +0530, Santosh Shukla wrote: >>> From: santosh shukla >>> >>> Add non-global symbol .LLl2x0_regs_phys to avoid build break in thumb2 mode. >>> >>> IIUC, arm assembler fail to load value of "global" variable >>> l2xo_regs_phys for thum2 mode and wrapping it in non-global symbol like >>> .Ll2x0_regs_phys solves the build break issue. >>> >>> arch/arm/mach-exynos/sleep.S: Assembler messages: >>> arch/arm/mach-exynos/sleep.S:57: Error: invalid immediate for address >>> calculation (value = 0x00000004) >>> >>> fix inspired from [1] >>> >>> [1] https://lkml.org/lkml/2010/3/31/235 >>> >>> Signed-off-by: santosh shukla >> >> Reviewed-by: Dave Martin >> > > Thanks. > > Hi Kukjin, if this patch ok with you then can you pick it up. > Sure, I've applied this into fixes for 3.16. Thanks, Kukjin >> The binutils folks insist that this is not a bug in gas. (I disagreed, but >> it's a grey area.) This is the established pattern for working round this >> issue -- looks fine to me. >> >> Cheers >> ---Dave From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Thu, 12 Jun 2014 00:13:53 +0900 Subject: [PATCH] ARM: Exynos : Fix build error with thumb2 In-Reply-To: References: <1401119625-11309-1-git-send-email-santosh.shukla@linaro.org> <20140602101023.GB3855@e103592.cambridge.arm.com> Message-ID: <53987231.6080200@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/04/14 17:07, Santosh Shukla wrote: > On 2 June 2014 15:40, Dave Martin wrote: >> On Mon, May 26, 2014 at 09:23:45PM +0530, Santosh Shukla wrote: >>> From: santosh shukla >>> >>> Add non-global symbol .LLl2x0_regs_phys to avoid build break in thumb2 mode. >>> >>> IIUC, arm assembler fail to load value of "global" variable >>> l2xo_regs_phys for thum2 mode and wrapping it in non-global symbol like >>> .Ll2x0_regs_phys solves the build break issue. >>> >>> arch/arm/mach-exynos/sleep.S: Assembler messages: >>> arch/arm/mach-exynos/sleep.S:57: Error: invalid immediate for address >>> calculation (value = 0x00000004) >>> >>> fix inspired from [1] >>> >>> [1] https://lkml.org/lkml/2010/3/31/235 >>> >>> Signed-off-by: santosh shukla >> >> Reviewed-by: Dave Martin >> > > Thanks. > > Hi Kukjin, if this patch ok with you then can you pick it up. > Sure, I've applied this into fixes for 3.16. Thanks, Kukjin >> The binutils folks insist that this is not a bug in gas. (I disagreed, but >> it's a grey area.) This is the established pattern for working round this >> issue -- looks fine to me. >> >> Cheers >> ---Dave