From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 1B184E00C24; Wed, 11 Jun 2014 10:44:08 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=HTML_MESSAGE autolearn=ham version=3.3.1 X-Spam-HAM-Report: * 0.0 HTML_MESSAGE BODY: HTML included in message Received: from www.dynamicdevices.co.uk (www.dynamicdevices.co.uk [89.200.136.37]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 4F042E0082A for ; Wed, 11 Jun 2014 10:44:01 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by www.dynamicdevices.co.uk (Postfix) with ESMTP id 934A827E02B; Wed, 11 Jun 2014 17:44:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at lennoab2.miniserver.com Received: from www.dynamicdevices.co.uk ([127.0.0.1]) by localhost (www.dynamicdevices.co.uk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BkddWatBc47U; Wed, 11 Jun 2014 17:43:58 +0000 (UTC) Received: from [127.0.0.1] (cpc32-live22-2-0-cust59.17-2.cable.virginm.net [82.36.253.60]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by www.dynamicdevices.co.uk (Postfix) with ESMTPSA id 52EE427E02A; Wed, 11 Jun 2014 17:43:58 +0000 (UTC) Message-ID: <5398955A.1090006@dynamicdevices.co.uk> Date: Wed, 11 Jun 2014 18:43:54 +0100 From: Alex J Lennon User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Andrei Gherzan References: <5397947A.6050605@dynamicdevices.co.uk> In-Reply-To: X-Enigmail-Version: 1.6 Cc: Yocto Project Subject: Re: [meta-raspberrypi][PATCH 1/1] gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio. X-BeenThere: yocto@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Discussion of all things Yocto Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jun 2014 17:44:08 -0000 Content-Type: multipart/alternative; boundary="------------040202030702040108080301" --------------040202030702040108080301 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/06/2014 18:24, Andrei Gherzan wrote: > > > On Wed, Jun 11, 2014 at 11:19 AM, Alex J Lennon > > > wrote: > > > On 11/06/2014 08:47, Andrei Gherzan wrote: >> >> >> >> On Wed, Jun 11, 2014 at 2:27 AM, Alex J Lennon >> > > wrote: >> >> >> On 10/06/2014 19:59, Andrei Gherzan wrote: >>> Hello Alex. >>> >>> On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon >>> >> > wrote: >>> >>> This changes the build slightly as there are some >>> #ifdefs in there for Raspberry Pi. >>> >>> Also the codec configuration file used by >>> gstreamer1.0-omx codecs, /etc/xdg/gstomx.conf, is set >>> correctly to core-name=/usr/lib/libopenmaxil.so >>> >>> Change-Id: I2352ecabfd053717d9ccd2d22422e7d4b7588ce4 >>> Signed-off-by: Alex J Lennon >>> >> > >>> --- >>> recipes-multimedia/gstreamer/gstreamer1.0-omx.inc >>> | 2 ++ >>> recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend >>> | 1 + >>> >>> >>> I was thinking we we really need two files for this... I >>> know that yocto has an inc too. But i don't know if that >>> really makes sense for one line. What do you think? >>> >> >> I came across Yocto best practice here. This is more or less >> why I provided a patch for consideration into Poky on this >> earlier today. It would help me, and I suspect other newbies, >> to have best practice expectations on how to put patches >> together somewhere up front, say in the README. >> >> "Do not merge .inc / .bb files" >> >> https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating >> >> >> >> I understand. But I think that this is the case only for bb >> files. We are talking here about a bbappend in which case this >> would be pretty useless. Nobody reuses an inc for a bbappend - >> never seen something like that. > > e.g. I have gstreamer1.0-omx_git.bbappend here which reuses the > .inc file. I didn't contribute it as for some reason the git build > breaks and I need to look at why this is > > > So, you say that if you merge your inc file in the bbappend one, the > build breaks? It shouldn't really. I just tested and for me it works. > Not quite. I mean that I am reusing the code in the .inc file in another .bbappend file, called gstreamer1.0-omx_git.bbappend This is identical to gstreamer1.0-omx_1.0.0.bbappend in that it just requires the inc file, so I don't have duplication of code. Targetting gstreamer-omx 1.0.0 at the RPi works fine, but when I tried targetting the git source at RPi the build broke, so I didn't provide that recipe to you. e.g. with my local.conf set to PREFERRED_VERSION_gstreamer1.0-omx = "git" the git build gives this cc1: error: .../tmp/sysroots/raspberrypi/usr/include/vc: No such file or directory [-Werror] cc1: error: .../tmp/sysroots/raspberrypi/usr/include/interface: No such file or directory [-Werror] cc1: error: .../tmp/sysroots/raspberrypi/usr/include/interface/vcos: No such file or directory [-Werror] cc1: error: .../tmp/sysroots/raspberrypi/usr/include/interface/vcos/pthreads: No such file or directory $ cc1: all warnings being treated as errors make[2]: *** [libgstomx_la-gstomxvideoenc.lo] Error 1 make[2]: *** Waiting for unfinished jobs.... I think there's something missing or some path not set correctly for the more recent gstreamer-omx code, but I haven't had a chance to look into it. > By the way, I would use _append_raspberrypi for this one too. > > > OK, I just tried this instead of the anonymous python method I created in the last patch-set. Perhaps I'm misunderstanding but, for example, we need GSTREAMER_1_0_OMX_TARGET set to 'rpi" when machine is raspberrypi When I try, GSTREAMER_1_0_OMX_TARGET_append_raspberrypi = "rpi" I end up with the original value 'bellagio' appended with 'rpi' to give 'bellagiorpi' Maybe I need something more like this? GSTREAMER_1_0_OMX_TARGET_override_raspberrypi = "rpi" Does such a mechanism exist in bitbake? Regards, Alex --------------040202030702040108080301 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
On 11/06/2014 18:24, Andrei Gherzan wrote:


On Wed, Jun 11, 2014 at 11:19 AM, Alex J Lennon <ajlennon@dynamicdevices.co.uk> wrote:

On 11/06/2014 08:47, Andrei Gherzan wrote:



On Wed, Jun 11, 2014 at 2:27 AM, Alex J Lennon <ajlennon@dynamicdevices.co.uk> wrote:

On 10/06/2014 19:59, Andrei Gherzan wrote:
Hello Alex.

On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon <ajlennon@dynamicdevices.co.uk> wrote:
This changes the build slightly as there are some #ifdefs in there for Raspberry Pi.

Also the codec configuration file used by gstreamer1.0-omx codecs, /etc/xdg/gstomx.conf,  is set correctly to core-name=/usr/lib/libopenmaxil.so

Change-Id: I2352ecabfd053717d9ccd2d22422e7d4b7588ce4
Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
---
 recipes-multimedia/gstreamer/gstreamer1.0-omx.inc            | 2 ++
 recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 +

I was thinking we we really need two files for this... I know that yocto has an inc too. But i don't know if that really makes sense for one line. What do you think? 
 

I came across Yocto best practice here. This is more or less why I provided a patch for consideration into Poky on this earlier today. It would help me, and I suspect other newbies, to have best practice expectations on how to put patches together somewhere up front, say in the README.

"Do not merge .inc / .bb files"

https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating

I understand. But I think that this is the case only for bb files. We are talking here about a bbappend in which case this would be pretty useless. Nobody reuses an inc for a bbappend - never seen something like that. 

e.g. I have gstreamer1.0-omx_git.bbappend here which reuses the .inc file. I didn't contribute it as for some reason the git build breaks and I need to look at why this is


So, you say that if you merge your inc file in the bbappend one, the build breaks? It shouldn't really. I just tested and for me it works. 


Not quite. I mean that I am reusing the code in the .inc file in another .bbappend file, called gstreamer1.0-omx_git.bbappend

This is identical to gstreamer1.0-omx_1.0.0.bbappend in that it just requires the inc file, so I don't have duplication of code.

Targetting gstreamer-omx 1.0.0 at the RPi works fine, but when I tried targetting the git source at RPi the build broke, so I didn't provide that recipe to you.

e.g. with my local.conf set to PREFERRED_VERSION_gstreamer1.0-omx = "git" the git build gives this

cc1: error: .../tmp/sysroots/raspberrypi/usr/include/vc: No such file or directory [-Werror]
cc1: error: .../tmp/sysroots/raspberrypi/usr/include/interface: No such file or directory [-Werror]
cc1: error: .../tmp/sysroots/raspberrypi/usr/include/interface/vcos: No such file or directory [-Werror]
cc1: error: .../tmp/sysroots/raspberrypi/usr/include/interface/vcos/pthreads: No such file or directory $
cc1: all warnings being treated as errors
make[2]: *** [libgstomx_la-gstomxvideoenc.lo] Error 1
make[2]: *** Waiting for unfinished jobs....

I think there's something missing or some path not set correctly for the more recent gstreamer-omx code, but I haven't had a chance to look into it.

By the way, I would use _append_raspberrypi for this one too.




OK, I just tried this instead of the anonymous python method I created in the last patch-set.

Perhaps I'm misunderstanding but, for example, we need GSTREAMER_1_0_OMX_TARGET set to 'rpi" when machine is raspberrypi

When I try,

GSTREAMER_1_0_OMX_TARGET_append_raspberrypi = "rpi"

I end up with the original value 'bellagio' appended with 'rpi' to give 'bellagiorpi'

Maybe I need something more like this?

GSTREAMER_1_0_OMX_TARGET_override_raspberrypi = "rpi"

Does such a mechanism exist in bitbake?

Regards,

Alex

--------------040202030702040108080301--