From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 0/4] Input: atmel_mxt_ts - make it work on Tegra Date: Wed, 11 Jun 2014 12:17:20 -0600 Message-ID: <53989D30.1000605@wwwdotorg.org> References: <1399414392-32572-1-git-send-email-swarren@wwwdotorg.org> <536963A0.4060506@wwwdotorg.org> <536BAA5A.1010809@itdev.co.uk> <536BB3C9.8070908@wwwdotorg.org> <536BDFFD.4080009@itdev.co.uk> <537128D0.3060005@wwwdotorg.org> <53763B06.7020100@itdev.co.uk> <53763F95.6000609@wwwdotorg.org> <537B8087.1040306@itdev.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from avon.wwwdotorg.org ([70.85.31.133]:57089 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752640AbaFKSRY (ORCPT ); Wed, 11 Jun 2014 14:17:24 -0400 In-Reply-To: <537B8087.1040306@itdev.co.uk> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Nick Dyer Cc: Dmitry Torokhov , Benson Leung , Yufeng Shen , Daniel Kurtz , "linux-input@vger.kernel.org" , Stephen Warren , "Bowens, Alan" On 05/20/2014 10:19 AM, Nick Dyer wrote: > Stephen Warren wrote: >> On 05/16/2014 10:21 AM, Nick Dyer wrote: >>> Thanks for this. Would you be happy for me to pick these changes up and >>> include them along with the other work I am sending to Dmitry? I am just >>> beginning to do various updates to the whole series, one of the things I >>> need to sort out is the device tree support. >> >> That would be fine. I assume you'd only take the 2 Atmel driver patches. >> I'll send the Tegra patches separately once the driver is merged. > > Great! Dmitry has merged some of the patches I sent now, so I'm just > working on updating to take account of that and adding the device tree > changes, and taking account of a couple of other review comments. ... >>> I will need to add device tree parameters for the touchscreen as well as >>> the touchpad, of course. >>> >>> By the way, the driver should work without any firmware file and just use >>> the firmware and configuration from NVRAM - request_firmware() returns a >>> failure and it continues through mxt_initialize(). >> >> Hmmm. I couldn't get that to work after applying the patches you posted. >> However, it did with what's already in linux-next plus the patches I sent. > > I will test this on my setup and see if I can figure out what is causing > the problem. Nick, did you get anywhere reproducing my problem? Unfortunately with your recent patches merged, I can't get the touchpad working at all, whereas before I had a few simple patches that made it work:-(