From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 6/8] xen: arm: add some helpers for assessing p2m pte Date: Wed, 11 Jun 2014 22:39:32 +0100 Message-ID: <5398CC94.5040802@linaro.org> References: <1402504640.16332.50.camel@kazak.uk.xensource.com> <1402504804-29173-6-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1402504804-29173-6-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 11/06/14 17:40, Ian Campbell wrote: > Not terribly helpful right now, since they aren't widely used, but makes future > patches easier to read. > > Signed-off-by: Ian Campbell > --- > v2: clarify common on p2m_{table,entry} > --- > xen/arch/arm/p2m.c | 21 ++++++++++++++------- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > index 8a6d295..2a93ff9 100644 > --- a/xen/arch/arm/p2m.c > +++ b/xen/arch/arm/p2m.c > @@ -14,6 +14,13 @@ > #define P2M_FIRST_ORDER 1 > #define P2M_FIRST_ENTRIES (LPAE_ENTRIES< > +#define p2m_valid(pte) ((pte).p2m.valid) > +/* These two can only be used on L0..L2 ptes because L3 mappings set > + * the table bit and therefore these would return the opposite to what > + * you would expect. */ > +#define p2m_table(pte) (p2m_valid(pte) && (pte).p2m.table) > +#define p2m_entry(pte) (p2m_valid(pte) && !(pte).p2m.table) Sorry, I didn't spot it on the previous version. You are using twice pte here. Depending on how complex pte we may duplicate the operation (masking the address + dereference the table). I'm wondering if we need a temporary variable in both p2m_table and p2m_entry. It seems that in your patch #7, you always use these 2 macros with non-complex variable. So I'm fine with one or the other way: Acked-by: Julien Grall Regards, -- Julien Grall