All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <clm@fb.com>
To: Filipe David Borba Manana <fdmanana@gmail.com>,
	<linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: fix qgroups sanity test crash or hang
Date: Wed, 11 Jun 2014 20:35:05 -0400	[thread overview]
Message-ID: <5398F5B9.3000207@fb.com> (raw)
In-Reply-To: <1402531956-27668-1-git-send-email-fdmanana@gmail.com>

On 06/11/2014 08:12 PM, Filipe David Borba Manana wrote:
> Often when running the qgroups sanity test, a crash or a hang happened.
> This is because the extent buffer the test uses for the root node doesn't
> have an header level explicitly set, making it have a random level value.
> This is a problem when it's not zero for the btrfs_search_slot() calls
> the test ends up doing, resulting in crashes or hangs such as the following:
> 

> Therefore initialize the extent buffer as an empty leaf (level 0).
> 
> Issue easy to reproduce when btrfs is built as a module via:
> 
>     $ for ((i = 1; i <= 1000000; i++)); do rmmod btrfs; modprobe btrfs; done

Nice, thanks Filipe, I hadn't been able to trigger this yet.

-chris

  reply	other threads:[~2014-06-12  0:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-12  0:12 [PATCH] Btrfs: fix qgroups sanity test crash or hang Filipe David Borba Manana
2014-06-12  0:35 ` Chris Mason [this message]
2014-06-12 15:43   ` Filipe David Manana
2014-06-12  1:47 ` [PATCH v2] " Filipe David Borba Manana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5398F5B9.3000207@fb.com \
    --to=clm@fb.com \
    --cc=fdmanana@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.