From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <53995A84.1090908@atmel.com> Date: Thu, 12 Jun 2014 15:45:08 +0800 From: Bo Shen MIME-Version: 1.0 To: Nicolas Ferre Subject: Re: [PATCH] mtd: atmel_nand: make ecc parameters same as definition References: <1402041728-12056-1-git-send-email-voice.shen@atmel.com> <53958CCE.5080307@atmel.com> <5397CBF9.800@atmel.com> <539954CD.5080309@atmel.com> <53995630.6040902@atmel.com> In-Reply-To: <53995630.6040902@atmel.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Cc: Josh Wu , computersforpeace@gmail.com, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Nicolas, On 06/12/2014 03:26 PM, Nicolas Ferre wrote: > On 12/06/2014 09:20, Josh Wu : >> Hi, Bo >> >> On 6/11/2014 11:24 AM, Bo Shen wrote: >>> Hi Josh, >>> >>> On 06/09/2014 06:30 PM, Josh Wu wrote: >>>> Hi, Bo >>>> >>>> Thanks for the patch. >>>> >>>> On 6/6/2014 4:02 PM, Bo Shen wrote: >>>>> If the ecc parameter is not the same as definition, when the >>>>> mtd core check these parameters, it will give the unexpected >>>>> result. >>>> Could you be more specific to tell what kind of result will happened? >>> >>> For example: >>> When try to calculate how many bits can correct in one page according >>> to the definition, it will give the wrong result. >>> >>> one page correct bits = (mtd->writesize * ecc->strength) / ecc->size; >>> >>> take the following use case as an example: >>> mtd->writesize = 2048 bytes, >>> ecc->strength = 4 bytes, (for 512 bytes) >>> >>> before this patch, the ecc->size = 2048, so the result is 4 bytes. >>> >>> after this patch, the ecc->size = 512, so the result is 16 bytes. >>> >>> The maximum correct bytes is 16 bytes while not 4 bytes. So, if not align >> >> That is clear enough, thanks. The patch is fine to me. so >> Acked-by: Josh Wu > > So I advice to add this additional information to the commit message: > Can you send a v2 with enhanced commit message. OK, no problem. > Thanks, bye, > Best Regards, Bo Shen From mboxrd@z Thu Jan 1 00:00:00 1970 From: voice.shen@atmel.com (Bo Shen) Date: Thu, 12 Jun 2014 15:45:08 +0800 Subject: [PATCH] mtd: atmel_nand: make ecc parameters same as definition In-Reply-To: <53995630.6040902@atmel.com> References: <1402041728-12056-1-git-send-email-voice.shen@atmel.com> <53958CCE.5080307@atmel.com> <5397CBF9.800@atmel.com> <539954CD.5080309@atmel.com> <53995630.6040902@atmel.com> Message-ID: <53995A84.1090908@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Nicolas, On 06/12/2014 03:26 PM, Nicolas Ferre wrote: > On 12/06/2014 09:20, Josh Wu : >> Hi, Bo >> >> On 6/11/2014 11:24 AM, Bo Shen wrote: >>> Hi Josh, >>> >>> On 06/09/2014 06:30 PM, Josh Wu wrote: >>>> Hi, Bo >>>> >>>> Thanks for the patch. >>>> >>>> On 6/6/2014 4:02 PM, Bo Shen wrote: >>>>> If the ecc parameter is not the same as definition, when the >>>>> mtd core check these parameters, it will give the unexpected >>>>> result. >>>> Could you be more specific to tell what kind of result will happened? >>> >>> For example: >>> When try to calculate how many bits can correct in one page according >>> to the definition, it will give the wrong result. >>> >>> one page correct bits = (mtd->writesize * ecc->strength) / ecc->size; >>> >>> take the following use case as an example: >>> mtd->writesize = 2048 bytes, >>> ecc->strength = 4 bytes, (for 512 bytes) >>> >>> before this patch, the ecc->size = 2048, so the result is 4 bytes. >>> >>> after this patch, the ecc->size = 512, so the result is 16 bytes. >>> >>> The maximum correct bytes is 16 bytes while not 4 bytes. So, if not align >> >> That is clear enough, thanks. The patch is fine to me. so >> Acked-by: Josh Wu > > So I advice to add this additional information to the commit message: > Can you send a v2 with enhanced commit message. OK, no problem. > Thanks, bye, > Best Regards, Bo Shen