From: Paolo Bonzini <pbonzini@redhat.com>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Fam Zheng" <famz@redhat.com>,
"Anthony Liguori" <aliguori@amazon.com>,
"Juan Quintela" <quintela@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Alexander Graf" <agraf@suse.de>,
qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Amit Shah" <amit.shah@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice
Date: Thu, 12 Jun 2014 10:55:42 +0200 [thread overview]
Message-ID: <53996B0E.4040808@redhat.com> (raw)
In-Reply-To: <20140612094351.6295fd38@bahia.local>
Il 12/06/2014 09:43, Greg Kurz ha scritto:
> Since we know that 0 < max_nr_ports < 32, is it acceptable to guess
> the correct endianness with a heuristic ?
>
> if (max_nr_ports > tswap32(s->config.max_nr_ports)) {
> max_nr_ports = bswap32(max_nr_ports);
> }
>
> if (max_nr_ports > tswap32(s->config.max_nr_ports)) {
> return -EINVAL;
> }
Yes, I guess it is acceptable. So first you should fix the code to
always serialize fields as big-endian, and then apply this little hack
and virtio_tswap on top of the previous change.
Paolo
next prev parent reply other threads:[~2014-06-12 8:56 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 15:41 [Qemu-devel] [PATCH RFC 0/8] virtio: migrate new properties Greg Kurz
2014-05-14 15:41 ` [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream Greg Kurz
2014-05-15 6:04 ` Amit Shah
2014-05-15 6:23 ` Michael S. Tsirkin
2014-05-15 6:46 ` Amit Shah
2014-05-15 7:04 ` Greg Kurz
2014-05-15 9:20 ` Andreas Färber
2014-05-15 9:52 ` Michael S. Tsirkin
2014-05-15 9:58 ` Andreas Färber
2014-05-15 10:03 ` Michael S. Tsirkin
2014-05-15 10:11 ` Andreas Färber
2014-05-15 10:16 ` Michael S. Tsirkin
2014-05-15 12:00 ` Andreas Färber
2014-05-15 12:20 ` Michael S. Tsirkin
2014-05-15 13:47 ` Markus Armbruster
2014-05-15 13:49 ` Greg Kurz
2014-05-15 12:33 ` Markus Armbruster
2014-05-15 12:58 ` Michael S. Tsirkin
2014-05-15 13:35 ` Greg Kurz
2014-05-15 10:08 ` Greg Kurz
2014-05-15 10:12 ` Michael S. Tsirkin
2014-05-15 10:21 ` Greg Kurz
2014-05-15 10:16 ` Greg Kurz
2014-05-16 9:14 ` Fam Zheng
2014-05-16 9:22 ` Andreas Färber
2014-05-16 9:40 ` Fam Zheng
2014-05-16 9:48 ` Greg Kurz
2014-05-17 18:29 ` Michael S. Tsirkin
2014-05-15 7:14 ` Michael S. Tsirkin
2014-05-15 6:49 ` Greg Kurz
2014-05-15 6:55 ` Amit Shah
2014-05-15 7:12 ` Michael S. Tsirkin
2014-05-14 15:41 ` [Qemu-devel] [PATCH RFC 2/8] virtio-net: migrate subsections Greg Kurz
2014-05-14 15:41 ` [Qemu-devel] [PATCH RFC 3/8] virtio-blk: " Greg Kurz
2014-05-14 15:42 ` [Qemu-devel] [PATCH RFC 4/8] virtio-scsi: " Greg Kurz
2014-05-14 15:42 ` [Qemu-devel] [PATCH RFC 5/8] virtio-serial: " Greg Kurz
2014-05-14 15:42 ` [Qemu-devel] [PATCH RFC 6/8] virtio-balloon: " Greg Kurz
2014-05-14 15:42 ` [Qemu-devel] [PATCH RFC 7/8] virtio-rng: " Greg Kurz
2014-05-14 15:42 ` [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice Greg Kurz
[not found] ` <5384A8D2.8050104@redhat.com>
[not found] ` <20140529111253.4ff55199@bahia.local>
[not found] ` <538708FA.4070309@redhat.com>
2014-06-12 7:43 ` Greg Kurz
2014-06-12 7:54 ` Michael S. Tsirkin
2014-06-12 8:47 ` Greg Kurz
2014-06-12 9:05 ` Michael S. Tsirkin
2014-06-12 9:06 ` Alexander Graf
2014-06-12 8:55 ` Alexander Graf
2014-06-12 9:07 ` Michael S. Tsirkin
2014-06-12 9:08 ` Alexander Graf
2014-06-12 8:55 ` Paolo Bonzini [this message]
2014-06-12 8:57 ` Alexander Graf
2014-06-12 9:06 ` Greg Kurz
2014-06-12 9:19 ` Paolo Bonzini
2014-06-12 9:37 ` Michael S. Tsirkin
2014-06-12 9:39 ` Paolo Bonzini
2014-06-12 9:43 ` Alexander Graf
2014-06-12 10:14 ` Greg Kurz
2014-06-12 10:39 ` Alexander Graf
2014-06-12 10:50 ` Greg Kurz
2014-06-12 10:58 ` Alexander Graf
2014-06-12 10:59 ` Michael S. Tsirkin
2014-06-12 11:10 ` Greg Kurz
2014-06-12 10:57 ` Michael S. Tsirkin
2014-06-12 10:56 ` Michael S. Tsirkin
2014-06-12 10:55 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2014-05-19 8:38 [Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties Greg Kurz
2014-05-19 8:39 ` [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice Greg Kurz
2014-05-19 13:06 ` Greg Kurz
2014-05-19 17:06 ` Andreas Färber
2014-05-19 17:32 ` Greg Kurz
2014-05-19 18:07 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53996B0E.4040808@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aliguori@amazon.com \
--cc=amit.shah@redhat.com \
--cc=famz@redhat.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.