From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v5 03/19] clean root dir of all x86-ness
Date: Thu, 12 Jun 2014 12:31:54 +0200
Message-ID: <5399819A.2030007@redhat.com>
References: <1402495294-30737-1-git-send-email-drjones@redhat.com> <1402495294-30737-4-git-send-email-drjones@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: christoffer.dall@linaro.org
To: Andrew Jones <drjones@redhat.com>, kvmarm@lists.cs.columbia.edu,
	kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-qc0-f176.google.com ([209.85.216.176]:48572 "EHLO
	mail-qc0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932998AbaFLKb6 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 12 Jun 2014 06:31:58 -0400
Received: by mail-qc0-f176.google.com with SMTP id w7so363491qcr.7
        for <kvm@vger.kernel.org>; Thu, 12 Jun 2014 03:31:57 -0700 (PDT)
In-Reply-To: <1402495294-30737-4-git-send-email-drjones@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 11/06/2014 16:01, Andrew Jones ha scritto:
> diff --git a/configure b/configure
> index d0c62e24dd1d2..6cfc64943f6e6 100755
> --- a/configure
> +++ b/configure
> @@ -15,6 +15,7 @@ usage() {
>  	Usage: $0 [options]
>
>  	Options include:
> +	    --test-dir=DIR         the main directory for tests ($arch)
>  	    --arch=ARCH            architecture to compile for ($arch)
>  	    --cross-prefix=PREFIX  cross compiler prefix
>  	    --cc=CC		   c compiler to use ($cc)
> @@ -33,6 +34,9 @@ while [[ "$1" = -* ]]; do
>  	opt="${opt%%=*}"
>      fi
>      case "$opt" in
> +	--test-dir)
> +	    testdir="$arg"
> +	    ;;
>  	--prefix)
>  	    prefix="$arg"
>  	    ;;
> @@ -62,6 +66,18 @@ while [[ "$1" = -* ]]; do
>  	    ;;
>      esac
>  done
> +if [ -z "$testdir" -a \( "$arch" = "i386" -o "$arch" = "x86_64" \) ]; then
> +    testdir=x86
> +elif [ -z "$testdir" ]; then
> +    testdir=$arch
> +fi
> +if [ ! -d $testdir ]; then
> +    echo "$testdir does not exist!"
> +    exit 1
> +fi
> +if [ -f $testdir/run ]; then
> +    ln -fs $testdir/run $testdir-run
> +fi

Why is --test-dir useful?  Can you just use --arch instead?

> diff --git a/docs/testdev.txt b/docs/testdev.txt
> new file mode 100644
> index 0000000000000..854fe20d56f66
> --- /dev/null
> +++ b/docs/testdev.txt
> @@ -0,0 +1,13 @@
> +This file describes the virtual device of qemu for supporting this
> +test suite.
> +
> +Services supplied by the testdev device:
> + serial output:		write-only, on io port 0xf1
> + exit process:		write-only, on io port 0xf4, value used as
> +			the exit code
> + ram size:		read-only, on io port 0xd1, 4 bytes' size
> + irq line setting:	write-only, on io ports 0x2000 - 0x2018,
> +			value to set/clear
> + simple io:		read/write, on io port 0xe0, 1/2/4 bytes
> +
> +The test device uses a char device for actual output.

I'm removing this file altogether and adding it to QEMU instead.  Most 
of the content is obsolete too.