From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [Xen-Devel] [PATCH] [GSOC14] refactored mempaging code from xenpaging to libxc. Date: Thu, 12 Jun 2014 14:29:17 +0100 Message-ID: <5399AB2D.5040307@citrix.com> References: <1402565030-22004-1-git-send-email-myselfdushyantbehl@gmail.com> <5399A984.6010300@citrix.com> <1402579640.26678.7.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1402579640.26678.7.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: andres.lagarcavilla@gmail.com, xen-devel@lists.xen.org, Dushyant Behl , dave.scott@eu.citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 12/06/14 14:27, Ian Campbell wrote: > On Thu, 2014-06-12 at 14:22 +0100, Andrew Cooper wrote: >>> +# mem paging setup >>> +GUEST_SRCS-y += xc_mem_paging_setup.c >>> + >> I don't think you need the comment here. It is obvious from the name of >> the file, although I would suggest you name it "xc_dom_paging.c" or >> something a tad less specific. > xc_dom_* are, for better or worse, generally domain builder related. > > Given the API is xen_mem_paging_* I don't think the name here is so bad, > I might be inclined to drop the _setup if there is any chance of > anything else being added here. > > Hmm yes I suppose. I would certainly drop the _setup, but "xc_mem_paging.c" is fine. ~Andrew