From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH v5 RFC 11/14] tools/libxc: x86 HVM save code
Date: Thu, 12 Jun 2014 16:55:19 +0100
Message-ID: <5399CD67.10109@citrix.com>
References: <1402510482-21099-1-git-send-email-andrew.cooper3@citrix.com>
	<1402510482-21099-12-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1402510482-21099-12-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
Cc: Frediano Ziglio <frediano.ziglio@citrix.com>, David Vrabel <david.vrabel@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 11/06/14 19:14, Andrew Cooper wrote:
> --- /dev/null
> +++ b/tools/libxc/saverestore/save_x86_hvm.c
...
> +static int write_hvm_params(struct context *ctx)
> +{
...
> +
> +    for ( i = 0; i < ARRAY_SIZE(params); i++ )
> +    {
> +        uint32_t index = params[i];
> +        uint64_t value;
> +
> +        rc = xc_get_hvm_param(xch, ctx->domid, index, (unsigned long *)&value);
> +        if ( rc )
> +        {
> +            /* Gross XenServer hack. Consider HVM_PARAM_CONSOLE_PFN failure
> +             * nonfatal. This is related to the fact it is impossible to
> +             * distinguish "no console" from a console at pfn/evtchn 0.
> +             *
> +             * TODO - find a compatible way to fix this.
> +             */
> +            if ( index == HVM_PARAM_CONSOLE_PFN )
> +                continue;

Um. Is this really needed with upstream Xen?

David