From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] cmd_mmc: make mmc dev always re-probe the HW
Date: Thu, 12 Jun 2014 10:19:08 -0600 [thread overview]
Message-ID: <5399D2FC.3080700@wwwdotorg.org> (raw)
In-Reply-To: <15F70FA9-6890-4480-9838-9CB9F03B062A@antoniou-consulting.com>
On 06/12/2014 05:31 AM, Pantelis Antoniou wrote:
> On May 23, 2014, at 10:24 PM, Stephen Warren wrote:
>> Currently, U-Boot behaves as follows:
>>
>> - Begin with no SD card inserted in "mmc 1"
>> - Execute: mmc dev 1
>> - This fails, since there is no card
>> - User plugs in an SD card
>> - Execute: mmc dev 1
>> - This still fails, since the HW isn't reprobed.
>>
>> With this change, U-Boot behaves as follows:
>>
>> - Begin with no SD card inserted in "mmc 1"
>> - Execute: mmc dev 1
>> - This fails, since there is no card
>> - User plugs in an SD card
>> - Execute: mmc dev 1
>> - The newly present SD card is detected
...
> Thanks, applied.
>
> -- Pantelis
>
> Acked-by: Pantelis Antoniou <panto@antoniou-consulting.com>
Thanks very much for applying these.
I'm puzzled why you write Acked-by in the emails, and add it to the
commit descriptions when you apply them? FWIW for reference: Acked-by as
used by the Linux kernel is usually only used when giving permission to
a different maintainer to apply the patches, rather than taking them
through the usual tree. Signed-off-by is the tag usually used when
applying commits yourself, although there's an unresolved question re:
whether adding s-o-b (or presumably anything at all) to commits when
applying them is appropriate behaviour for U-Boot.
next prev parent reply other threads:[~2014-06-12 16:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 19:24 [U-Boot] [PATCH 1/3] cmd_mmc: add force_init parameter to init_mmc_device() Stephen Warren
2014-05-23 19:24 ` [U-Boot] [PATCH 2/3] cmd_mmc: Use init_mmc_device() from do_mmc_rescan() Stephen Warren
2014-06-12 11:29 ` Pantelis Antoniou
2014-05-23 19:24 ` [U-Boot] [PATCH 3/3] cmd_mmc: make mmc dev always re-probe the HW Stephen Warren
2014-06-12 11:31 ` Pantelis Antoniou
2014-06-12 16:19 ` Stephen Warren [this message]
2014-06-12 16:24 ` Pantelis Antoniou
2014-05-30 21:12 ` [U-Boot] [PATCH 1/3] cmd_mmc: add force_init parameter to init_mmc_device() Stephen Warren
2014-06-02 4:59 ` Jaehoon Chung
2014-06-02 15:50 ` Stephen Warren
2014-06-10 16:01 ` Stephen Warren
2014-06-12 11:28 ` Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5399D2FC.3080700@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.