From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v5 RFC 14/14] tools/libxc: noarch restore
 code
Date: Thu, 12 Jun 2014 18:16:44 +0100
Message-ID: <5399E07C.1090604@citrix.com>
References: <1402510482-21099-1-git-send-email-andrew.cooper3@citrix.com>
	<1402510482-21099-15-git-send-email-andrew.cooper3@citrix.com>
	<5399CFAF.8000803@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5399CFAF.8000803@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>
Cc: Frediano Ziglio <frediano.ziglio@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 12/06/14 17:05, David Vrabel wrote:
> On 11/06/14 19:14, Andrew Cooper wrote:
>> --- a/tools/libxc/saverestore/common.h
>> +++ b/tools/libxc/saverestore/common.h
>> @@ -292,6 +292,12 @@ static inline int write_record(struct context *ctx, struct record *rec)
>>      return write_split_record(ctx, rec, NULL, 0);
>>  }
>>  
>> +/* TODO - find a better way of hiding this.  It should be private to
>> + * restore.c, but is needed by x86_pv_localise_page()
>> + */
>> +int populate_pfns(struct context *ctx, unsigned count,
>> +                  const xen_pfn_t *original_pfns, const uint32_t *types);
> I don't see a problem with this being here, if it's needed in those two
> places.
>
> David
>

I was hoping to find a way of making it disappear as it is the one ugly
lump in the otherwise clean partitioning of common and arch specific code.

I am however struggling...

~Andrew