From: Bernhard Praschinger <shadowlord@utanet.at>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: MJPEG-tools user list <mjpeg-users@lists.sourceforge.net>,
kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org,
dan.carpenter@oracle.com
Subject: Re: [Mjpeg-users] [patch] [media] zoran: remove duplicate ZR050_MO_COMP define
Date: Thu, 12 Jun 2014 17:28:55 +0000 [thread overview]
Message-ID: <5399E357.3040203@utanet.at> (raw)
In-Reply-To: <20140609152135.GQ9600@mwanda>
Hallo
More than 15 years have passed since the first working module for a
zoran chipset based PCI card existed. Well not included into the Linux
kernel at that time.
According to my experience, the driver started to make problems when 64
Bit and more than 2GB Ram became popular. In May 2011 there was a patch
available that made the cards working in machines with more than 2GB
Ram, and AMD&Intel x64 architectures. According to my information that
patch did not make it into the linux kernel (the Patch was for the Linux
2.6.38 Kernel)
So people spend time looking at code that does not work (well it
compiles and does not cause troubles), and send patches the world will
never honor.
I haven't had a question related to a zoran based card's in years. So
I'm quite sure there are not much users out there that use a zoran based
video cards in a up to date environment.
Because of that I would really suggest that somebody removes the whole
zoran driver from the linux kernel.
Dan Carpenter wrote:
> The ZR050_MO_COMP define is cut and pasted twice so we can delete the
> second instance.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/media/pci/zoran/zr36050.h b/drivers/media/pci/zoran/zr36050.h
> index 9f52f0c..ea083ad 100644
> --- a/drivers/media/pci/zoran/zr36050.h
> +++ b/drivers/media/pci/zoran/zr36050.h
> @@ -126,7 +126,6 @@ struct zr36050 {
> /* zr36050 mode register bits */
>
> #define ZR050_MO_COMP 0x80
> -#define ZR050_MO_COMP 0x80
> #define ZR050_MO_ATP 0x40
> #define ZR050_MO_PASS2 0x20
> #define ZR050_MO_TLM 0x10
>
> ------------------------------------------------------------------------------
> HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
> Find What Matters Most in Your Big Data with HPCC Systems
> Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
> Leverages Graph Analysis for Fast Processing & Easy Data Exploration
> http://p.sf.net/sfu/hpccsystems
> _______________________________________________
> Mjpeg-users mailing list
> Mjpeg-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mjpeg-users
Kind Regards
Bernhard Praschinger
Docwriter, probably the last mjpegtools maintainer
WARNING: multiple messages have this Message-ID (diff)
From: Bernhard Praschinger <shadowlord@utanet.at>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: MJPEG-tools user list <mjpeg-users@lists.sourceforge.net>,
kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org,
dan.carpenter@oracle.com
Subject: Re: [Mjpeg-users] [patch] [media] zoran: remove duplicate ZR050_MO_COMP define
Date: Thu, 12 Jun 2014 19:28:55 +0200 [thread overview]
Message-ID: <5399E357.3040203@utanet.at> (raw)
In-Reply-To: <20140609152135.GQ9600@mwanda>
Hallo
More than 15 years have passed since the first working module for a
zoran chipset based PCI card existed. Well not included into the Linux
kernel at that time.
According to my experience, the driver started to make problems when 64
Bit and more than 2GB Ram became popular. In May 2011 there was a patch
available that made the cards working in machines with more than 2GB
Ram, and AMD&Intel x64 architectures. According to my information that
patch did not make it into the linux kernel (the Patch was for the Linux
2.6.38 Kernel)
So people spend time looking at code that does not work (well it
compiles and does not cause troubles), and send patches the world will
never honor.
I haven't had a question related to a zoran based card's in years. So
I'm quite sure there are not much users out there that use a zoran based
video cards in a up to date environment.
Because of that I would really suggest that somebody removes the whole
zoran driver from the linux kernel.
Dan Carpenter wrote:
> The ZR050_MO_COMP define is cut and pasted twice so we can delete the
> second instance.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/media/pci/zoran/zr36050.h b/drivers/media/pci/zoran/zr36050.h
> index 9f52f0c..ea083ad 100644
> --- a/drivers/media/pci/zoran/zr36050.h
> +++ b/drivers/media/pci/zoran/zr36050.h
> @@ -126,7 +126,6 @@ struct zr36050 {
> /* zr36050 mode register bits */
>
> #define ZR050_MO_COMP 0x80
> -#define ZR050_MO_COMP 0x80
> #define ZR050_MO_ATP 0x40
> #define ZR050_MO_PASS2 0x20
> #define ZR050_MO_TLM 0x10
>
> ------------------------------------------------------------------------------
> HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
> Find What Matters Most in Your Big Data with HPCC Systems
> Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
> Leverages Graph Analysis for Fast Processing & Easy Data Exploration
> http://p.sf.net/sfu/hpccsystems
> _______________________________________________
> Mjpeg-users mailing list
> Mjpeg-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mjpeg-users
Kind Regards
Bernhard Praschinger
Docwriter, probably the last mjpegtools maintainer
next prev parent reply other threads:[~2014-06-12 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 15:21 [patch] [media] zoran: remove duplicate ZR050_MO_COMP define Dan Carpenter
2014-06-09 15:21 ` Dan Carpenter
2014-06-12 17:28 ` Bernhard Praschinger [this message]
2014-06-12 17:28 ` [Mjpeg-users] " Bernhard Praschinger
2014-06-27 12:53 ` Hans Verkuil
2014-06-27 12:53 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5399E357.3040203@utanet.at \
--to=shadowlord@utanet.at \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=mjpeg-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.