From: Prabhakar Kushwaha <prabhakar@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fsl/pcie: Change 'no link' to 'undetermined' for pcie endpoint
Date: Fri, 13 Jun 2014 08:52:16 +0530 [thread overview]
Message-ID: <539A6E68.4010305@freescale.com> (raw)
In-Reply-To: <1402602563-26705-1-git-send-email-tie-fei.zang@freescale.com>
Hi Roy,
On 6/13/2014 1:19 AM, Roy Zang wrote:
> Even u-boot boots up, the pcie link may not setup correctly when
> Freescale SOC acts as endpoint.
> So change the link status from 'no link' to 'undetermined' to
> reduce the confusion.
> The link status can check from host side eventually.
>
> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> ---
> drivers/pci/fsl_pci_init.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/fsl_pci_init.c b/drivers/pci/fsl_pci_init.c
> index 3a41b0e..231b075 100644
> --- a/drivers/pci/fsl_pci_init.c
> +++ b/drivers/pci/fsl_pci_init.c
> @@ -504,8 +504,14 @@ void fsl_pci_init(struct pci_controller *hose, struct fsl_pci_info *pci_info)
> }
> #endif
> if (!enabled) {
> - /* Let the user know there's no PCIe link */
> - printf("no link, regs @ 0x%lx\n", pci_info->regs);
> + /* Let the user know there's no PCIe link for root
> + * complex. for endpoint, the link may not setup, so
> + * print undetermined.
> + */
> + if (fsl_is_pci_agent(hose))
> + printf("undetermined, regs @ 0x%lx\n", pci_info->regs);
As description of commit message saying "The link status can check from
host side eventually "
It will be good, if we can also print link status at this point to let
user know about status of end point.
-prabhakar
next prev parent reply other threads:[~2014-06-13 3:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 19:49 [U-Boot] [PATCH] fsl/pcie: Change 'no link' to 'undetermined' for pcie endpoint Roy Zang
2014-06-12 20:56 ` Wolfgang Denk
2014-06-20 20:56 ` Roy Zang
2014-06-13 3:22 ` Prabhakar Kushwaha [this message]
2014-06-20 20:58 ` Roy Zang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539A6E68.4010305@freescale.com \
--to=prabhakar@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.