From: Inki Dae <inki.dae@samsung.com>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 2/3] exynos: fix G2D_DOUBLE_TO_FIXED for non-integer input
Date: Fri, 13 Jun 2014 14:05:41 +0900 [thread overview]
Message-ID: <539A86A5.6060906@samsung.com> (raw)
In-Reply-To: <1401638646-4039-2-git-send-email-tjakobi@math.uni-bielefeld.de>
On 2014년 06월 02일 01:04, Tobias Jakobi wrote:
> The hardware accepts scaling factors formatted in a
> fixed-point format. The current macro casts to integer
> first, then multiplies by the fp conversion factor.
>
> This does not make any sense. In particular, truly
> 'fractional' inputs, like 1.5, won't work that way.
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Thanks,
Inki Dae
>
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
> exynos/fimg2d.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/exynos/fimg2d.h b/exynos/fimg2d.h
> index 1aac378..4785e2f 100644
> --- a/exynos/fimg2d.h
> +++ b/exynos/fimg2d.h
> @@ -25,7 +25,7 @@
> #define G2D_MAX_CMD_LIST_NR 64
> #define G2D_PLANE_MAX_NR 2
>
> -#define G2D_DOUBLE_TO_FIXED(d) ((unsigned int)(d) * 65536.0)
> +#define G2D_DOUBLE_TO_FIXED(d) ((unsigned int)((d) * 65536.0))
>
> enum e_g2d_color_mode {
> /* COLOR FORMAT */
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-06-13 5:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 16:04 [PATCH v2 1/3] exynos: fix coordinate computation in g2d_copy Tobias Jakobi
2014-06-01 16:04 ` [PATCH v2 2/3] exynos: fix G2D_DOUBLE_TO_FIXED for non-integer input Tobias Jakobi
2014-06-13 5:05 ` Inki Dae [this message]
2014-06-01 16:04 ` [PATCH v2 3/3] exynos: fix scaling factor computation in g2d_copy_with_scale Tobias Jakobi
2014-06-13 5:06 ` Inki Dae
2014-06-13 5:06 ` [PATCH v2 1/3] exynos: fix coordinate computation in g2d_copy Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539A86A5.6060906@samsung.com \
--to=inki.dae@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.