From mboxrd@z Thu Jan 1 00:00:00 1970 From: a.hajda@samsung.com (Andrzej Hajda) Date: Fri, 13 Jun 2014 07:54:45 +0200 Subject: [PATCH v2 1/2] drm/panel: remove unnecessary dependencies In-Reply-To: References: Message-ID: <539A9225.90304@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Russel, Thanks for both fixes. Just one nitpick. On 06/12/2014 06:09 PM, Russell King wrote: > DRM_PANEL_LD9040 and DRM_PANEL_S6E8AA0 both explicitly depended on > DRM_PANEL && DRM. This is nonsense for two reasons: > > (a) DRM_PANEL already depends on DRM, so DRM_PANEL can not be enabled > without DRM first being enabled. Hence the && DRM is useless. This reason is invalid and do not describe the patch anymore. Regards Andrzej > > (b) These two configs are already beneath a menu which depends on > DRM_PANEL being enabled; these options will not be visible without > DRM_PANEL already being enabled. > > Let's just remove this unnecessary verbosity. > > Signed-off-by: Russell King > --- > drivers/gpu/drm/panel/Kconfig | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 4ec874da5668..d83958d39f43 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -5,7 +5,7 @@ config DRM_PANEL > Panel registration and lookup framework. > > menu "Display Panels" > - depends on DRM_PANEL > + depends on DRM && DRM_PANEL > > config DRM_PANEL_SIMPLE > tristate "support for simple panels" > @@ -18,14 +18,12 @@ config DRM_PANEL_SIMPLE > > config DRM_PANEL_LD9040 > tristate "LD9040 RGB/SPI panel" > - depends on DRM && DRM_PANEL > depends on OF > select SPI > select VIDEOMODE_HELPERS > > config DRM_PANEL_S6E8AA0 > tristate "S6E8AA0 DSI video mode panel" > - depends on DRM && DRM_PANEL > depends on OF > select DRM_MIPI_DSI > select VIDEOMODE_HELPERS > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [PATCH v2 1/2] drm/panel: remove unnecessary dependencies Date: Fri, 13 Jun 2014 07:54:45 +0200 Message-ID: <539A9225.90304@samsung.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by gabe.freedesktop.org (Postfix) with ESMTP id 59F9A6E243 for ; Thu, 12 Jun 2014 22:54:51 -0700 (PDT) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N7300G2WF3BJE00@mailout3.w1.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 13 Jun 2014 06:54:47 +0100 (BST) In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King , David Airlie , Thierry Reding Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann List-Id: dri-devel@lists.freedesktop.org Hi Russel, Thanks for both fixes. Just one nitpick. On 06/12/2014 06:09 PM, Russell King wrote: > DRM_PANEL_LD9040 and DRM_PANEL_S6E8AA0 both explicitly depended on > DRM_PANEL && DRM. This is nonsense for two reasons: > > (a) DRM_PANEL already depends on DRM, so DRM_PANEL can not be enabled > without DRM first being enabled. Hence the && DRM is useless. This reason is invalid and do not describe the patch anymore. Regards Andrzej > > (b) These two configs are already beneath a menu which depends on > DRM_PANEL being enabled; these options will not be visible without > DRM_PANEL already being enabled. > > Let's just remove this unnecessary verbosity. > > Signed-off-by: Russell King > --- > drivers/gpu/drm/panel/Kconfig | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 4ec874da5668..d83958d39f43 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -5,7 +5,7 @@ config DRM_PANEL > Panel registration and lookup framework. > > menu "Display Panels" > - depends on DRM_PANEL > + depends on DRM && DRM_PANEL > > config DRM_PANEL_SIMPLE > tristate "support for simple panels" > @@ -18,14 +18,12 @@ config DRM_PANEL_SIMPLE > > config DRM_PANEL_LD9040 > tristate "LD9040 RGB/SPI panel" > - depends on DRM && DRM_PANEL > depends on OF > select SPI > select VIDEOMODE_HELPERS > > config DRM_PANEL_S6E8AA0 > tristate "S6E8AA0 DSI video mode panel" > - depends on DRM && DRM_PANEL > depends on OF > select DRM_MIPI_DSI > select VIDEOMODE_HELPERS >