* [PATCH v2] builddeb: fix missing headers in linux-headers package
@ 2014-04-15 11:51 Fathi Boudra
2014-04-25 6:12 ` Fathi Boudra
2014-06-13 11:39 ` Michal Marek
0 siblings, 2 replies; 7+ messages in thread
From: Fathi Boudra @ 2014-04-15 11:51 UTC (permalink / raw)
To: linux-kbuild; +Cc: Michal Marek, Ben Hutchings, Maximilian Attems, Fathi Boudra
The kernel headers package (linux-headers) doesn't include several
header files required to build out-of-tree modules.
It makes the package unusable on e.g. ARM architecture:
/usr/src/linux-headers-3.14.0/arch/arm/include/asm/memory.h:24:25:
fatal error: mach/memory.h: No such file or directory
#include <mach/memory.h>
^
compilation terminated.
Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
---
Changes from v1:
- add missing module.lds, mips/Kbuild.platforms and Platform files
- generically look for all include directories in arch/$SRCARCH
scripts/package/builddeb | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index f46e4dd..42b1e20 100644
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -287,9 +287,11 @@ EOF
fi
-# Build header package
+# Build kernel header package
(cd $srctree; find . -name Makefile\* -o -name Kconfig\* -o -name \*.pl > "$objtree/debian/hdrsrcfiles")
(cd $srctree; find arch/$SRCARCH/include include scripts -type f >> "$objtree/debian/hdrsrcfiles")
+(cd $srctree; find arch/$SRCARCH -name module.lds -o -name Kbuild.platforms -o -name Platform >> "$objtree/debian/hdrsrcfiles")
+(cd $srctree; find $(find arch/$SRCARCH -name include -o -name scripts -type d) -type f >> "$objtree/debian/hdrsrcfiles")
(cd $objtree; find arch/$SRCARCH/include Module.symvers include scripts -type f >> "$objtree/debian/hdrobjfiles")
destdir=$kernel_headers_dir/usr/src/linux-headers-$version
mkdir -p "$destdir"
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] builddeb: fix missing headers in linux-headers package
2014-04-15 11:51 [PATCH v2] builddeb: fix missing headers in linux-headers package Fathi Boudra
@ 2014-04-25 6:12 ` Fathi Boudra
2014-05-09 6:42 ` Fathi Boudra
2014-06-13 11:39 ` Michal Marek
1 sibling, 1 reply; 7+ messages in thread
From: Fathi Boudra @ 2014-04-25 6:12 UTC (permalink / raw)
To: linux-kbuild; +Cc: Michal Marek, Ben Hutchings, Maximilian Attems, Fathi Boudra
Ben, Michal, what about this patch?
On 15 April 2014 14:51, Fathi Boudra <fathi.boudra@linaro.org> wrote:
> The kernel headers package (linux-headers) doesn't include several
> header files required to build out-of-tree modules.
>
> It makes the package unusable on e.g. ARM architecture:
> /usr/src/linux-headers-3.14.0/arch/arm/include/asm/memory.h:24:25:
> fatal error: mach/memory.h: No such file or directory
> #include <mach/memory.h>
> ^
> compilation terminated.
>
> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
> ---
> Changes from v1:
> - add missing module.lds, mips/Kbuild.platforms and Platform files
> - generically look for all include directories in arch/$SRCARCH
>
> scripts/package/builddeb | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index f46e4dd..42b1e20 100644
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -287,9 +287,11 @@ EOF
>
> fi
>
> -# Build header package
> +# Build kernel header package
> (cd $srctree; find . -name Makefile\* -o -name Kconfig\* -o -name \*.pl > "$objtree/debian/hdrsrcfiles")
> (cd $srctree; find arch/$SRCARCH/include include scripts -type f >> "$objtree/debian/hdrsrcfiles")
> +(cd $srctree; find arch/$SRCARCH -name module.lds -o -name Kbuild.platforms -o -name Platform >> "$objtree/debian/hdrsrcfiles")
> +(cd $srctree; find $(find arch/$SRCARCH -name include -o -name scripts -type d) -type f >> "$objtree/debian/hdrsrcfiles")
> (cd $objtree; find arch/$SRCARCH/include Module.symvers include scripts -type f >> "$objtree/debian/hdrobjfiles")
> destdir=$kernel_headers_dir/usr/src/linux-headers-$version
> mkdir -p "$destdir"
> --
> 1.9.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] builddeb: fix missing headers in linux-headers package
2014-04-25 6:12 ` Fathi Boudra
@ 2014-05-09 6:42 ` Fathi Boudra
2014-06-13 5:14 ` Fathi Boudra
0 siblings, 1 reply; 7+ messages in thread
From: Fathi Boudra @ 2014-05-09 6:42 UTC (permalink / raw)
To: linux-kbuild; +Cc: Michal Marek, Ben Hutchings, Fathi Boudra
gentle ping
On 25 April 2014 09:12, Fathi Boudra <fathi.boudra@linaro.org> wrote:
> Ben, Michal, what about this patch?
>
> On 15 April 2014 14:51, Fathi Boudra <fathi.boudra@linaro.org> wrote:
>> The kernel headers package (linux-headers) doesn't include several
>> header files required to build out-of-tree modules.
>>
>> It makes the package unusable on e.g. ARM architecture:
>> /usr/src/linux-headers-3.14.0/arch/arm/include/asm/memory.h:24:25:
>> fatal error: mach/memory.h: No such file or directory
>> #include <mach/memory.h>
>> ^
>> compilation terminated.
>>
>> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
>> ---
>> Changes from v1:
>> - add missing module.lds, mips/Kbuild.platforms and Platform files
>> - generically look for all include directories in arch/$SRCARCH
>>
>> scripts/package/builddeb | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
>> index f46e4dd..42b1e20 100644
>> --- a/scripts/package/builddeb
>> +++ b/scripts/package/builddeb
>> @@ -287,9 +287,11 @@ EOF
>>
>> fi
>>
>> -# Build header package
>> +# Build kernel header package
>> (cd $srctree; find . -name Makefile\* -o -name Kconfig\* -o -name \*.pl > "$objtree/debian/hdrsrcfiles")
>> (cd $srctree; find arch/$SRCARCH/include include scripts -type f >> "$objtree/debian/hdrsrcfiles")
>> +(cd $srctree; find arch/$SRCARCH -name module.lds -o -name Kbuild.platforms -o -name Platform >> "$objtree/debian/hdrsrcfiles")
>> +(cd $srctree; find $(find arch/$SRCARCH -name include -o -name scripts -type d) -type f >> "$objtree/debian/hdrsrcfiles")
>> (cd $objtree; find arch/$SRCARCH/include Module.symvers include scripts -type f >> "$objtree/debian/hdrobjfiles")
>> destdir=$kernel_headers_dir/usr/src/linux-headers-$version
>> mkdir -p "$destdir"
>> --
>> 1.9.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] builddeb: fix missing headers in linux-headers package
2014-05-09 6:42 ` Fathi Boudra
@ 2014-06-13 5:14 ` Fathi Boudra
0 siblings, 0 replies; 7+ messages in thread
From: Fathi Boudra @ 2014-06-13 5:14 UTC (permalink / raw)
To: linux-kbuild; +Cc: Michal Marek, Ben Hutchings
Michal,
This patch is sitting here since 2 months without any reply and you
just sent the pull request for 3.16-rc1.
The linux-headers package is broken...
On 9 May 2014 09:42, Fathi Boudra <fathi.boudra@linaro.org> wrote:
> gentle ping
>
> On 25 April 2014 09:12, Fathi Boudra <fathi.boudra@linaro.org> wrote:
>> Ben, Michal, what about this patch?
>>
>> On 15 April 2014 14:51, Fathi Boudra <fathi.boudra@linaro.org> wrote:
>>> The kernel headers package (linux-headers) doesn't include several
>>> header files required to build out-of-tree modules.
>>>
>>> It makes the package unusable on e.g. ARM architecture:
>>> /usr/src/linux-headers-3.14.0/arch/arm/include/asm/memory.h:24:25:
>>> fatal error: mach/memory.h: No such file or directory
>>> #include <mach/memory.h>
>>> ^
>>> compilation terminated.
>>>
>>> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
>>> ---
>>> Changes from v1:
>>> - add missing module.lds, mips/Kbuild.platforms and Platform files
>>> - generically look for all include directories in arch/$SRCARCH
>>>
>>> scripts/package/builddeb | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
>>> index f46e4dd..42b1e20 100644
>>> --- a/scripts/package/builddeb
>>> +++ b/scripts/package/builddeb
>>> @@ -287,9 +287,11 @@ EOF
>>>
>>> fi
>>>
>>> -# Build header package
>>> +# Build kernel header package
>>> (cd $srctree; find . -name Makefile\* -o -name Kconfig\* -o -name \*.pl > "$objtree/debian/hdrsrcfiles")
>>> (cd $srctree; find arch/$SRCARCH/include include scripts -type f >> "$objtree/debian/hdrsrcfiles")
>>> +(cd $srctree; find arch/$SRCARCH -name module.lds -o -name Kbuild.platforms -o -name Platform >> "$objtree/debian/hdrsrcfiles")
>>> +(cd $srctree; find $(find arch/$SRCARCH -name include -o -name scripts -type d) -type f >> "$objtree/debian/hdrsrcfiles")
>>> (cd $objtree; find arch/$SRCARCH/include Module.symvers include scripts -type f >> "$objtree/debian/hdrobjfiles")
>>> destdir=$kernel_headers_dir/usr/src/linux-headers-$version
>>> mkdir -p "$destdir"
>>> --
>>> 1.9.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] builddeb: fix missing headers in linux-headers package
2014-04-15 11:51 [PATCH v2] builddeb: fix missing headers in linux-headers package Fathi Boudra
2014-04-25 6:12 ` Fathi Boudra
@ 2014-06-13 11:39 ` Michal Marek
2014-06-15 15:19 ` Ben Hutchings
1 sibling, 1 reply; 7+ messages in thread
From: Michal Marek @ 2014-06-13 11:39 UTC (permalink / raw)
To: Fathi Boudra, Ben Hutchings; +Cc: linux-kbuild, Maximilian Attems
Dne 15.4.2014 13:51, Fathi Boudra napsal(a):
> The kernel headers package (linux-headers) doesn't include several
> header files required to build out-of-tree modules.
>
> It makes the package unusable on e.g. ARM architecture:
> /usr/src/linux-headers-3.14.0/arch/arm/include/asm/memory.h:24:25:
> fatal error: mach/memory.h: No such file or directory
> #include <mach/memory.h>
> ^
> compilation terminated.
>
> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
> ---
> Changes from v1:
> - add missing module.lds, mips/Kbuild.platforms and Platform files
> - generically look for all include directories in arch/$SRCARCH
Ben, is this version OK to merge? Does the package now match the
official Debian ones?
Thanks,
Michal
> scripts/package/builddeb | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index f46e4dd..42b1e20 100644
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -287,9 +287,11 @@ EOF
>
> fi
>
> -# Build header package
> +# Build kernel header package
> (cd $srctree; find . -name Makefile\* -o -name Kconfig\* -o -name \*.pl > "$objtree/debian/hdrsrcfiles")
> (cd $srctree; find arch/$SRCARCH/include include scripts -type f >> "$objtree/debian/hdrsrcfiles")
> +(cd $srctree; find arch/$SRCARCH -name module.lds -o -name Kbuild.platforms -o -name Platform >> "$objtree/debian/hdrsrcfiles")
> +(cd $srctree; find $(find arch/$SRCARCH -name include -o -name scripts -type d) -type f >> "$objtree/debian/hdrsrcfiles")
> (cd $objtree; find arch/$SRCARCH/include Module.symvers include scripts -type f >> "$objtree/debian/hdrobjfiles")
> destdir=$kernel_headers_dir/usr/src/linux-headers-$version
> mkdir -p "$destdir"
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] builddeb: fix missing headers in linux-headers package
2014-06-13 11:39 ` Michal Marek
@ 2014-06-15 15:19 ` Ben Hutchings
2014-06-18 19:37 ` Michal Marek
0 siblings, 1 reply; 7+ messages in thread
From: Ben Hutchings @ 2014-06-15 15:19 UTC (permalink / raw)
To: Michal Marek; +Cc: Fathi Boudra, linux-kbuild, Maximilian Attems
[-- Attachment #1: Type: text/plain, Size: 2156 bytes --]
On Fri, 2014-06-13 at 13:39 +0200, Michal Marek wrote:
> Dne 15.4.2014 13:51, Fathi Boudra napsal(a):
> > The kernel headers package (linux-headers) doesn't include several
> > header files required to build out-of-tree modules.
> >
> > It makes the package unusable on e.g. ARM architecture:
> > /usr/src/linux-headers-3.14.0/arch/arm/include/asm/memory.h:24:25:
> > fatal error: mach/memory.h: No such file or directory
> > #include <mach/memory.h>
> > ^
> > compilation terminated.
> >
> > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
> > ---
> > Changes from v1:
> > - add missing module.lds, mips/Kbuild.platforms and Platform files
> > - generically look for all include directories in arch/$SRCARCH
>
> Ben, is this version OK to merge? Does the package now match the
> official Debian ones?
This is not exactly the same, but I think it's good.
Reviewed-by: Ben Hutchings <ben@decadent.org.uk>
Ben.
> Thanks,
> Michal
>
>
> > scripts/package/builddeb | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> > index f46e4dd..42b1e20 100644
> > --- a/scripts/package/builddeb
> > +++ b/scripts/package/builddeb
> > @@ -287,9 +287,11 @@ EOF
> >
> > fi
> >
> > -# Build header package
> > +# Build kernel header package
> > (cd $srctree; find . -name Makefile\* -o -name Kconfig\* -o -name \*.pl > "$objtree/debian/hdrsrcfiles")
> > (cd $srctree; find arch/$SRCARCH/include include scripts -type f >> "$objtree/debian/hdrsrcfiles")
> > +(cd $srctree; find arch/$SRCARCH -name module.lds -o -name Kbuild.platforms -o -name Platform >> "$objtree/debian/hdrsrcfiles")
> > +(cd $srctree; find $(find arch/$SRCARCH -name include -o -name scripts -type d) -type f >> "$objtree/debian/hdrsrcfiles")
> > (cd $objtree; find arch/$SRCARCH/include Module.symvers include scripts -type f >> "$objtree/debian/hdrobjfiles")
> > destdir=$kernel_headers_dir/usr/src/linux-headers-$version
> > mkdir -p "$destdir"
>
>
>
--
Ben Hutchings
Tomorrow will be cancelled due to lack of interest.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] builddeb: fix missing headers in linux-headers package
2014-06-15 15:19 ` Ben Hutchings
@ 2014-06-18 19:37 ` Michal Marek
0 siblings, 0 replies; 7+ messages in thread
From: Michal Marek @ 2014-06-18 19:37 UTC (permalink / raw)
To: Ben Hutchings; +Cc: Fathi Boudra, linux-kbuild, Maximilian Attems
Dne 15.6.2014 17:19, Ben Hutchings napsal(a):
> On Fri, 2014-06-13 at 13:39 +0200, Michal Marek wrote:
>> Dne 15.4.2014 13:51, Fathi Boudra napsal(a):
>>> The kernel headers package (linux-headers) doesn't include several
>>> header files required to build out-of-tree modules.
>>>
>>> It makes the package unusable on e.g. ARM architecture:
>>> /usr/src/linux-headers-3.14.0/arch/arm/include/asm/memory.h:24:25:
>>> fatal error: mach/memory.h: No such file or directory
>>> #include <mach/memory.h>
>>> ^
>>> compilation terminated.
>>>
>>> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
>>> ---
>>> Changes from v1:
>>> - add missing module.lds, mips/Kbuild.platforms and Platform files
>>> - generically look for all include directories in arch/$SRCARCH
>>
>> Ben, is this version OK to merge? Does the package now match the
>> official Debian ones?
>
> This is not exactly the same, but I think it's good.
>
> Reviewed-by: Ben Hutchings <ben@decadent.org.uk>
I applied the patch to kbuild.git#rc-fixes.
Thanks,
Michal
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-06-18 19:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-15 11:51 [PATCH v2] builddeb: fix missing headers in linux-headers package Fathi Boudra
2014-04-25 6:12 ` Fathi Boudra
2014-05-09 6:42 ` Fathi Boudra
2014-06-13 5:14 ` Fathi Boudra
2014-06-13 11:39 ` Michal Marek
2014-06-15 15:19 ` Ben Hutchings
2014-06-18 19:37 ` Michal Marek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.