From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Mason <clm@fb.com>
Subject: Re: [PATCH pre 3.16-rc1] bio: Fix build failure.
Date: Fri, 13 Jun 2014 10:34:59 -0400
Message-ID: <539B0C13.8040306@fb.com>
References: <201406132103.HCI73982.HFOOMFFSLVtJQO@I-love.SAKURA.ne.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: <linux-fsdevel@vger.kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	<viro@ZenIV.linux.org.uk>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:7432 "EHLO
	mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751719AbaFMOcq (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 13 Jun 2014 10:32:46 -0400
In-Reply-To: <201406132103.HCI73982.HFOOMFFSLVtJQO@I-love.SAKURA.ne.jp>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 06/13/2014 08:03 AM, Tetsuo Handa wrote:
>>>From 75b9f78ddc8ab30555a520f5a2477a9340341dd1 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Date: Fri, 13 Jun 2014 12:35:35 +0900
> Subject: [PATCH pre 3.16-rc1] bio: Fix build failure.
> 
> Commit 62a8067a7f "bio_vec-backed iov_iter" introduced an unnamed union
> inside a struct which gcc-4.4.7 cannot handle. Name the unnamed union as
> u in order to fix build failure.

Same problem here.  Jens tracked it down to the anon union and the named
initialization done in page_io.c

> diff --git a/mm/page_io.c b/mm/page_io.c
> index 243a9b7..875a460 100644
> --- a/mm/page_io.c
> +++ b/mm/page_io.c
> @@ -274,7 +274,7 @@ int __swap_writepage(struct page *page, struct writeback_control *wbc,
>  			.count = PAGE_SIZE,
>  			.iov_offset = 0,
>  			.nr_segs = 1,
> -			.bvec = &bv
> +			.u.bvec = &bv
>  		};
>  
>  		init_sync_kiocb(&kiocb, swap_file);
> 


-chris