From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [Xen-Devel] [PATCH] [GSOC14] refactored mempaging code from xenpaging to libxc. Date: Fri, 13 Jun 2014 16:06:15 +0100 Message-ID: <539B1367.6000304@citrix.com> References: <5399BD31.506@citrix.com> <1402668965-5434-1-git-send-email-myselfdushyantbehl@gmail.com> <539B0FD6.6080700@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dushyant Behl Cc: Andres Lagar Cavilla , Stefano Stabellini , dave.scott@eu.citrix.com, Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 13/06/14 16:00, Dushyant Behl wrote: >>> -CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenstore) $(PTHREAD_CFLAGS) >>> -LDLIBS += $(LDLIBS_libxenctrl) $(LDLIBS_libxenstore) $(PTHREAD_LIBS) >>> +CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenguest) $(CFLAGS_libxenstore) $(PTHREAD_CFLAGS) >>> +LDLIBS += $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenstore) $(PTHREAD_LIBS) >> You are not introducing any libxenstore calls into xenpaging. This >> change is bogus. > Sorry but, I have only introduced libxenguest flags and libs, because > the file xc_mem_paging_ring_setup.c which I have created is compiled > into libxenguest, hence the dependency. > libxenstore on the other hand was already present here because > xenpaging.c has a used a lot of libxenstore calls. Oh sorry - my mistake. I misread that as an introduction of libxenstore, whereas it is actually an insertion of libxenguest into the middle. That's fine then. ~Andrew