From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?Christian_K=F6nig?= Subject: Re: [PATCH 1/3] drm/radeon: stop poisoning the GART TLB Date: Fri, 13 Jun 2014 17:45:36 +0200 Message-ID: <539B1CA0.6010600@vodafone.de> References: <1401888598-1961-1-git-send-email-deathsimple@vodafone.de> <5398218A.4040104@vodafone.de> <53998D99.6050008@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from pegasos-out.vodafone.de (pegasos-out.vodafone.de [80.84.1.38]) by gabe.freedesktop.org (Postfix) with ESMTP id 39D416EA80 for ; Fri, 13 Jun 2014 08:45:51 -0700 (PDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by pegasos-out.vodafone.de (Rohrpostix1 Daemon) with ESMTP id 7A9AD260763 for ; Fri, 13 Jun 2014 17:45:48 +0200 (CEST) Received: from pegasos-out.vodafone.de ([127.0.0.1]) by localhost (rohrpostix1.prod.vfnet.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 28tEuh-75MIW for ; Fri, 13 Jun 2014 17:45:43 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?windows-1252?Q?Marek_Ol=9A=E1k?= Cc: dri-devel List-Id: dri-devel@lists.freedesktop.org Hi Marek, ah, yes! Piglit in combination with that patch can indeed crash the box. Going to investigate now that I can reproduce it. Thanks, Christian. Am 13.06.2014 15:19, schrieb Marek Ol=9A=E1k: > Hi, > > With my "force_gtt" patch, Cape Verde is unstable too, so all GCN > chips are affected. > > I recommend applying that patch, because it will reproduce the problem > faster. Without it, the hangs are very rare and it may take a while > before they occur. > > Marek > > On Thu, Jun 12, 2014 at 1:23 PM, Christian K=F6nig > wrote: >> Please do so, and you might want to try 3.15.0 as well. >> >> I've tested multiple piglit runs over night with my Bonaire and 3.15.0 a= nd >> that seemed to work perfectly fine. >> >> Going to test Alex drm-next-3.16 a bit more as well. >> >> Christian. >> >> Am 11.06.2014 12:56, schrieb Marek Ol=9A=E1k: >> >>> I only tested Bonaire. I can test Cape Verde if needed. >>> >>> Marek >>> >>> On Wed, Jun 11, 2014 at 11:29 AM, Christian K=F6nig >>> wrote: >>>> Crap, I already wanted to check back with you if that really fixes your >>>> problems. >>>> >>>> Thanks for the info, this crash also only happens on CIK doesn't it? >>>> >>>> Christian. >>>> >>>> Am 11.06.2014 01:30, schrieb Marek Ol=9A=E1k: >>>> >>>>> Sorry to tell you the bad news. This patch doesn't fix the hangs on my >>>>> machine. >>>>> >>>>> I tested drm-next-3.16 from Alex's tree. I also switched copying from >>>>> SDMA to CP DMA, which hung too. >>>>> >>>>> I also tried this: >>>>> >>>>> git checkout (the problematic commit): >>>>> 6d2f294 - drm/radeon: use normal BOs for the page tables v4 >>>>> >>>>> git cherry-pick (fixes): >>>>> 0e97703c - drm/radeon: add define for flags used in R600+ GTT >>>>> 0986c1a5 - drm/radeon: stop poisoning the GART TLB >>>>> 4906f689 - drm/radeon: fix page directory update size estimation >>>>> 4b095566 - drm/radeon: fix buffer placement under memory pressure v2 >>>>> >>>>> Then I tested both SDMA and CP DMA copying. Both were unstable. >>>>> >>>>> Testing was done with piglit / quick.tests. >>>>> >>>>> Marek >>>>> >>>>> >>>>> On Wed, Jun 4, 2014 at 3:29 PM, Christian K=F6nig >>>>> >>>>> wrote: >>>>>> From: Christian K=F6nig >>>>>> >>>>>> When we set the valid bit on invalid GART entries they are >>>>>> loaded into the TLB when an adjacent entry is loaded. This >>>>>> poisons the TLB with invalid entries which are sometimes >>>>>> not correctly removed on TLB flush. >>>>>> >>>>>> For stable inclusion the patch probably needs to be modified a bit. >>>>>> >>>>>> Signed-off-by: Christian K=F6nig >>>>>> Cc: stable@vger.kernel.org >>>>>> --- >>>>>> drivers/gpu/drm/radeon/rs600.c | 5 ++++- >>>>>> 1 file changed, 4 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/drivers/gpu/drm/radeon/rs600.c >>>>>> b/drivers/gpu/drm/radeon/rs600.c >>>>>> index 0a8be63..e0465b2 100644 >>>>>> --- a/drivers/gpu/drm/radeon/rs600.c >>>>>> +++ b/drivers/gpu/drm/radeon/rs600.c >>>>>> @@ -634,7 +634,10 @@ int rs600_gart_set_page(struct radeon_device >>>>>> *rdev, >>>>>> int i, uint64_t addr) >>>>>> return -EINVAL; >>>>>> } >>>>>> addr =3D addr & 0xFFFFFFFFFFFFF000ULL; >>>>>> - addr |=3D R600_PTE_GART; >>>>>> + if (addr =3D=3D rdev->dummy_page.addr) >>>>>> + addr |=3D R600_PTE_SYSTEM | R600_PTE_SNOOPED; >>>>>> + else >>>>>> + addr |=3D R600_PTE_GART; >>>>>> writeq(addr, ptr + (i * 8)); >>>>>> return 0; >>>>>> } >>>>>> -- >>>>>> 1.9.1 >>>>>> >>>>>> _______________________________________________ >>>>>> dri-devel mailing list >>>>>> dri-devel@lists.freedesktop.org >>>>>> http://lists.freedesktop.org/mailman/listinfo/dri-devel >>>>