Re: [PATCHv2 1/2] ibmvscsi: Abort init sequence during error recovery

[Brian King <brking@linux.vnet.ibm.com>]

On 06/13/2014 10:49 AM, James Bottomley wrote:
> On Fri, 2014-06-13 at 10:30 -0500, Brian King wrote:
>> On 05/27/2014 08:55 AM, Nathan Fontenot wrote:
>>> On 05/23/2014 10:52 AM, Brian King wrote:
>>>> If a CRQ reset is triggered for some reason while in the middle
>>>> of performing VSCSI adapter initialization, we don't want to
>>>> call the done function for the initialization MAD commands as
>>>> this will only result in two threads attempting initialization
>>>> at the same time, resulting in failures.
>>>>
>>>> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
>>>
>>> Acked-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
>>>
>>>> ---
>>>>
>>>>  drivers/scsi/ibmvscsi/ibmvscsi.c |    3 ++-
>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff -puN drivers/scsi/ibmvscsi/ibmvscsi.c~ibmvscsi_purge_fix drivers/scsi/ibmvscsi/ibmvscsi.c
>>>> --- linux/drivers/scsi/ibmvscsi/ibmvscsi.c~ibmvscsi_purge_fix	2014-05-23 10:36:04.000000000 -0500
>>>> +++ linux-bjking1/drivers/scsi/ibmvscsi/ibmvscsi.c	2014-05-23 10:50:03.000000000 -0500
>>>> @@ -797,7 +797,8 @@ static void purge_requests(struct ibmvsc
>>>>  				       evt->hostdata->dev);
>>>>  			if (evt->cmnd_done)
>>>>  				evt->cmnd_done(evt->cmnd);
>>>> -		} else if (evt->done)
>>>> +		} else if (evt->done && evt->crq.format != VIOSRP_MAD_FORMAT &&
>>>> +			   evt->iu.srp.login_req.opcode != SRP_LOGIN_REQ)
>>>>  			evt->done(evt);
>>>>  		free_event_struct(&evt->hostdata->pool, evt);
>>>>  		spin_lock_irqsave(hostdata->host->host_lock, flags);
>>>> _
>>
>> Hi James,
>>
>> Are these two patches in your queue? They both fix rather nasty issues
>> that have caused kernel crashes in our testing.
> 
> Should they be cc'd to stable, or are they recently introduced bugs?

They should probably go to stable as well as they've been around a while.

Thanks,

Brian

-- 
Brian King
Power Linux I/O
IBM Linux Technology Center