From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvUvC-0005lH-OZ for qemu-devel@nongnu.org; Fri, 13 Jun 2014 13:05:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvUv2-0003NY-DN for qemu-devel@nongnu.org; Fri, 13 Jun 2014 13:05:46 -0400 Received: from [2a03:4000:1::4e2f:c7ac:d] (port=48090 helo=v220110690675601.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvUv2-0003N0-6H for qemu-devel@nongnu.org; Fri, 13 Jun 2014 13:05:36 -0400 Message-ID: <539B2F58.50400@weilnetz.de> Date: Fri, 13 Jun 2014 19:05:28 +0200 From: Stefan Weil MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH]Fix two functions of the same name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lb peace , qemu-devel@nongnu.org Cc: afaerber@suse.de Am 13.06.2014 13:49, schrieb Lb peace: > It is funny that we have two sigbus_handler in our QEMU.(exec.c & > cpus.c)Change one's name. > > Signed-off-by: Peace > --- > cpus.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > Technically it does not matter whether two functions have the same name as long as both are in different compilation units (*.c files) and have only a local scope (that's what the 'static' keyword does). There are even function names in QEMU code which occur three or more times. Look for register_types, for example. They do you think this should be changed? The only reason I see is that setting breakpoints while debugging is a little bit more difficult. Regards Stefan