From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jaroslav Kysela <perex@perex.cz>
Subject: Re: [RFC][PATCH 0/2] Fix aplay and alsa-lib
 write_areas() freezing with 100% cpu usage on stuck slave pcm
Date: Fri, 13 Jun 2014 19:20:03 +0200
Message-ID: <539B32C3.2040901@perex.cz>
References: <1402642371.496174944@f39.i.mail.ru> <539ABED4.9000105@perex.cz>
 <1402661625.359891425@f87.i.mail.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mail1.perex.cz (mail1.perex.cz [77.48.224.245])
 by alsa0.perex.cz (Postfix) with ESMTP id 89BF7261ADB
 for <alsa-devel@alsa-project.org>; Fri, 13 Jun 2014 19:20:03 +0200 (CEST)
In-Reply-To: <1402661625.359891425@f87.i.mail.ru>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Sergey <sergemp@mail.ru>, alsa-devel <alsa-devel@alsa-project.org>
List-Id: alsa-devel@alsa-project.org

Date 13.6.2014 14:13, Sergey wrote:
> Fri, 13 Jun 2014 Jaroslav Kysela wrote:
> 
>>> First patch fixes snd_pcm_write_areas() stuck in a loop because of transfer
>>> func() always returning 0. That caused application calling it to freeze.
>>> In the example above it have frozen aplay. If it was called by firefox,
>>> it would freeze firefox.
>>>
>>> Is it a good way to fix it? Should snd_pcm_read_areas() be fixed like that too?
>>
>> Nope: The whole culprit was in the null plugin - the stream was not
>> started, thus new samples were not delivered.
>>
>> I tried to fix this in:
>>
>> http://git.alsa-project.org/?p=alsa-lib.git;a=commit;h=9c3086fb749cd5545be3f15cdde1592390006258
>>
>>> Second patch fixes aplay itself, not returning from pcm_write() after SIGINT.
>>
>> Thanks, looks good, but I added the in_aborting check to other
>> functions, too:
>>
>> http://git.alsa-project.org/?p=alsa-utils.git;a=commit;h=c06dbf077459923066c96556678835cd1f55123a
> 
> It works great. Thank you!
> 
> PS: What do you think about that small aplay patch?:
> http://mailman.alsa-project.org/pipermail/alsa-devel/2014-June/077665.html
> aplay -vvv output looks weird without it.

Thanks. Applied now.

				Jaroslav


-- 
Jaroslav Kysela <perex@perex.cz>
Linux Kernel Sound Maintainer
ALSA Project; Red Hat, Inc.