All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Jimmy Picard <jimmyp11f155@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: fix coding style
Date: Sat, 14 Jun 2014 16:15:03 +0100	[thread overview]
Message-ID: <539C66F7.2040607@kernel.org> (raw)
In-Reply-To: <1402638961-14176-1-git-send-email-jimmyp11f155@gmail.com>

On 13/06/14 06:56, Jimmy Picard wrote:
> This patch fixes coding style reported by checkpatch.pl that missing
> a blank line after declarations.
>
> Signed-off-by: Jimmy Picard <jimmyp11f155@gmail.com>
Hmm. This is in the trivial enough to be marginally annoying
category of basically noise.  Normally I'd only take this as
part of a larger series doing something more interesting, but
what the heck.

Applied to the togreg branch of iio.git

J
> ---
>   drivers/staging/iio/iio_simple_dummy.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/iio/iio_simple_dummy.c b/drivers/staging/iio/iio_simple_dummy.c
> index fd334a0..bf78e6f 100644
> --- a/drivers/staging/iio/iio_simple_dummy.c
> +++ b/drivers/staging/iio/iio_simple_dummy.c
> @@ -550,6 +550,7 @@ error_ret:
>   static __init int iio_dummy_init(void)
>   {
>   	int i, ret;
> +
>   	if (instances > 10) {
>   		instances = 1;
>   		return -EINVAL;
> @@ -577,6 +578,7 @@ module_init(iio_dummy_init);
>   static __exit void iio_dummy_exit(void)
>   {
>   	int i;
> +
>   	for (i = 0; i < instances; i++)
>   		iio_dummy_remove(i);
>   	kfree(iio_dummy_devs);
>


  reply	other threads:[~2014-06-14 15:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13  5:56 [PATCH] staging: iio: fix coding style Jimmy Picard
2014-06-14 15:15 ` Jonathan Cameron [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-06-12  9:42 Jimmy P
2014-06-12 16:10 ` Greg Kroah-Hartman
2014-04-09 18:09 Joel Porquet
2014-04-12 17:28 ` Jonathan Cameron
2014-04-14  9:40   ` Dan O'Donovan
2014-04-14 13:59   ` Joël Porquet
2014-04-14 16:10     ` Jonathan Cameron
2014-06-14 15:21 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539C66F7.2040607@kernel.org \
    --to=jic23@kernel.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jimmyp11f155@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.