All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] nbd: Drop nbd_can_read()
Date: Sat, 14 Jun 2014 20:31:35 +0200	[thread overview]
Message-ID: <539C9507.7010106@redhat.com> (raw)
In-Reply-To: <539C0071.6040709@redhat.com>

On 14.06.2014 09:57, Paolo Bonzini wrote:
> Il 14/06/2014 00:30, Max Reitz ha scritto:
>> +static void nbd_set_handlers(NBDClient *client)
>> +{
>> +    if (client->exp && client->exp->ctx) {
>> +        aio_set_fd_handler(client->exp->ctx, client->sock,
>> +                           client->can_read ? nbd_read : NULL,
>> +                           client->restart_write ? nbd_restart_write 
>> : NULL,
>
> Instead of client->restart_write you can just use 
> client->send_coroutine.  Apart from this, the patch is okay.

Oh, right, thanks.

Max

  reply	other threads:[~2014-06-14 18:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13 22:30 [Qemu-devel] [PATCH 0/3] nbd: Adapt for dataplane Max Reitz
2014-06-13 22:30 ` [Qemu-devel] [PATCH 1/3] nbd: Drop nbd_can_read() Max Reitz
2014-06-14  7:57   ` Paolo Bonzini
2014-06-14 18:31     ` Max Reitz [this message]
2014-06-13 22:30 ` [Qemu-devel] [PATCH 2/3] block: Add AIO context notifiers Max Reitz
2014-06-13 22:30 ` [Qemu-devel] [PATCH 3/3] nbd: Follow the BDS' AIO context Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539C9507.7010106@redhat.com \
    --to=mreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.