From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v5 18/21] xen/arm: Add virtual GICv3 support
Date: Sun, 15 Jun 2014 19:32:53 +0100
Message-ID: <539DE6D5.9040508@linaro.org>
References: <1402580192-13937-1-git-send-email-vijay.kilari@gmail.com>
	<1402580192-13937-19-git-send-email-vijay.kilari@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1402580192-13937-19-git-send-email-vijay.kilari@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

Hi Vijay,

I didn't look very closely to each part of this patch. But it looks good 
to me. I've only one question, see below.

On 12/06/14 14:36, vijay.kilari@gmail.com wrote:
> +static int vgic_v3_distr_mmio_write(struct vcpu *v, mmio_info_t *info)

[..]

> +    case GICD_IROUTER32 ... GICD_IROUTERN:
> +        if ( dabt.size != DABT_DOUBLE_WORD ) goto bad_width;
> +        rank = vgic_irq_rank(v, 64, gicd_reg - GICD_IROUTER, DABT_DOUBLE_WORD);

You've handled word read-access a bit above. Why don't you handle word 
write-access?

Regards,

-- 
Julien Grall