All of lore.kernel.org
 help / color / mirror / Atom feed
From: ipaton0@gmail.com (Iain Paton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: imx6qdl: use DT macro for clock ID
Date: Sun, 15 Jun 2014 20:51:51 +0100	[thread overview]
Message-ID: <539DF957.5080603@gmail.com> (raw)
In-Reply-To: <1402836147-29625-2-git-send-email-shawn.guo@freescale.com>

On 15/06/14 13:42, Shawn Guo wrote:
> Switch to use DT macro for clock ID, so that device tree source is more
> readable.

[...]
>  		aips1: aips-bus at 02000000 {
> @@ -87,7 +90,8 @@
>  				compatible = "fsl,imx6q-i2c", "fsl,imx21-i2c";
>  				reg = <0x021f8000 0x4000>;
>  				interrupts = <0 35 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clks 116>;
> +				/* Same clock as i.MX6Q ECSPI5 */
> +				clocks = <&clks IMX6QDL_CLK_ECSPI5>;
>  				status = "disabled";
>  			};
>  		};

Do you think it would it be worthwhile to define

+#define IMX6Q_CLK_ECSPI5	116
+#define IMX6DL_CLK_I2C4	116

in imx6qdl-clock.h from the first patch and use it here ?

I'm not particularly bothered either way, I just remember thinking the 
name in the enum could become a cause of confusion when I was looking 
at the changes for i2c4.

  reply	other threads:[~2014-06-15 19:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-15 12:42 [PATCH 1/2] ARM: imx6qdl: switch to use macro for clock ID Shawn Guo
2014-06-15 12:42 ` [PATCH 2/2] ARM: dts: imx6qdl: use DT " Shawn Guo
2014-06-15 19:51   ` Iain Paton [this message]
2014-06-16  1:44     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539DF957.5080603@gmail.com \
    --to=ipaton0@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.