From: maxime.coquelin@st.com (Maxime Coquelin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] ARM: STi: DT: Properly define sti-ethclk & stmmaceth for stih415/6
Date: Mon, 16 Jun 2014 13:28:05 +0200 [thread overview]
Message-ID: <539ED4C5.4070906@st.com> (raw)
In-Reply-To: <20140616092339.GB27978@griffinp-ThinkPad-X1-Carbon-2nd>
Hi Peter,
On 06/16/2014 11:23 AM, Peter Griffin wrote:
> This patch fixes two problems: -
>
> 1) The device tree isn't currently providing sti-ethclk which is
> required by the dwmac glue code to correctly configure the ethernet
> PHY clock speed.
>
> This means depending on what the bootloader/jtag has
> configured this clock to, and what switch/hub the board is plugged
> into you most likely will NOT successfully negotiate a ethernet link.
>
> 2) The stmmaceth clock was associated with the wrong clock. It was
> referencing the PHY clock rather than the interconnect clock which
> clocks the IP.
>
> This patch also brings us closer to not having to boot the upstream
> kernel with the clk_ignore_unused parameter.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> arch/arm/boot/dts/stih415.dtsi | 8 ++++----
> arch/arm/boot/dts/stih416.dtsi | 8 ++++----
> include/dt-bindings/clock/stih415-clks.h | 1 +
> include/dt-bindings/clock/stih416-clks.h | 1 +
> 4 files changed, 10 insertions(+), 8 deletions(-)
>
...
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
Thanks for the fix!
Maxime
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Coquelin <maxime.coquelin@st.com>
To: Peter Griffin <peter.griffin@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <patrice.chotard@st.com>,
<srinivas.kandagatla@gmail.com>
Cc: <lee.jones@linaro.org>, <gabriel.fernandez@st.com>,
<daniel.thompson@linaro.org>
Subject: Re: [PATCH V2] ARM: STi: DT: Properly define sti-ethclk & stmmaceth for stih415/6
Date: Mon, 16 Jun 2014 13:28:05 +0200 [thread overview]
Message-ID: <539ED4C5.4070906@st.com> (raw)
In-Reply-To: <20140616092339.GB27978@griffinp-ThinkPad-X1-Carbon-2nd>
Hi Peter,
On 06/16/2014 11:23 AM, Peter Griffin wrote:
> This patch fixes two problems: -
>
> 1) The device tree isn't currently providing sti-ethclk which is
> required by the dwmac glue code to correctly configure the ethernet
> PHY clock speed.
>
> This means depending on what the bootloader/jtag has
> configured this clock to, and what switch/hub the board is plugged
> into you most likely will NOT successfully negotiate a ethernet link.
>
> 2) The stmmaceth clock was associated with the wrong clock. It was
> referencing the PHY clock rather than the interconnect clock which
> clocks the IP.
>
> This patch also brings us closer to not having to boot the upstream
> kernel with the clk_ignore_unused parameter.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> arch/arm/boot/dts/stih415.dtsi | 8 ++++----
> arch/arm/boot/dts/stih416.dtsi | 8 ++++----
> include/dt-bindings/clock/stih415-clks.h | 1 +
> include/dt-bindings/clock/stih416-clks.h | 1 +
> 4 files changed, 10 insertions(+), 8 deletions(-)
>
...
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
Thanks for the fix!
Maxime
next prev parent reply other threads:[~2014-06-16 11:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 20:22 [PATCH] ARM: STi: DT: Properly define sti-ethclk & stmmaceth for stih415/6 Peter Griffin
2014-06-09 20:22 ` Peter Griffin
2014-06-09 20:30 ` Srinivas Kandagatla
2014-06-09 20:30 ` Srinivas Kandagatla
2014-06-16 9:01 ` Lee Jones
2014-06-16 9:01 ` Lee Jones
2014-06-16 9:19 ` Peter Griffin
2014-06-16 9:19 ` Peter Griffin
2014-06-16 9:23 ` [PATCH V2] " Peter Griffin
2014-06-16 9:23 ` Peter Griffin
2014-06-16 9:29 ` Lee Jones
2014-06-16 9:29 ` Lee Jones
2014-06-16 11:28 ` Maxime Coquelin [this message]
2014-06-16 11:28 ` Maxime Coquelin
2014-06-17 7:10 ` Lee Jones
2014-06-17 7:10 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539ED4C5.4070906@st.com \
--to=maxime.coquelin@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.