From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2 1/4] xentrace: Use PERROR from xc_private. instead of our own. Date: Mon, 16 Jun 2014 12:49:25 +0100 Message-ID: <539ED9C5.3010306@citrix.com> References: <1402692084-931-1-git-send-email-konrad.wilk@oracle.com> <1402692084-931-2-git-send-email-konrad.wilk@oracle.com> <539ED852.7060603@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <539ED852.7060603@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On 16/06/14 12:43, George Dunlap wrote: > On 06/13/2014 09:41 PM, Konrad Rzeszutek Wilk wrote: >> However, the xc_private PERROR uses 'xch' while we call said >> structure 'xc_handle' - so this patch also changes the variable >> to xch. >> >> Signed-off-by: Konrad Rzeszutek Wilk > > I wasn't sure whether "xc_private.h" was intended to be included by > tools outside the libxc directory, but it seems to be included by > xenpaging and a couple of random things inside tools/misc; so: > > Reviewed-by: George Dunlap I disagree - xc_private.h is private to libxc and should not be used outside of tools/libxc/* There are some naughty examples which should be fixed. If there are bits in xc_private.h which are needed by outside programs, then they should move to xen{ctrl,guest}.h as appropriate. ~Andrew