All of lore.kernel.org
 help / color / mirror / Atom feed
From: denis@eukrea.com (Denis Carikli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v14 09/10] ARM: dts: mbimx51sd: Add display support.
Date: Mon, 16 Jun 2014 14:29:00 +0200	[thread overview]
Message-ID: <539EE30C.4060502@eukrea.com> (raw)
In-Reply-To: <1402913484-25910-9-git-send-email-denis@eukrea.com>

On 06/16/2014 12:11 PM, Denis Carikli wrote:> +	reg_lcd_3v3: lcd-en {
 > +		compatible = "regulator-fixed";
 > +		pinctrl-names = "default";
 > +		pinctrl-0 = <&pinctrl_reg_lcd_3v3>;
 > +		regulator-name = "lcd-3v3";
 > +		regulator-min-microvolt = <3300000>;
 > +		regulator-max-microvolt = <3300000>;
 > +		gpio = <&gpio3 13 GPIO_ACTIVE_HIGH>;
 > +		regulator-boot-on;
 > +	};
 > +};
This is wrong, I'll fix it in the next serie.

What it really does is to make regulator-fixed think that the gpio is 
active low, the bindings documentation(fixed-regulator.txt) says:
 > - enable-active-high: Polarity of GPIO is Active high
 > If this property is missing, the default assumed is Active low.

Then regulator-boot-on will make it think that the regulator is already 
on and so the regulator will be disabled.
 From the bindings documentation (regulator.txt):
 > regulator-boot-on: bootloader/firmware enabled regulator

Which result at the lcd regulator being physically powered on at boot.
I didn't see that because powering it on at boot is what I want.

How can I do that beside doing it in userspace by issuing the following 
commands:
echo 4 > /sys/devices/display-subsystem/graphics/fb0/blank
echo 0 > /sys/devices/display-subsystem/graphics/fb0/blank

Denis.

WARNING: multiple messages have this Message-ID (diff)
From: Denis Carikli <denis@eukrea.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: devel@driverdev.osuosl.org,
	"Russell King" <linux@arm.linux.org.uk>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"David Airlie" <airlied@linux.ie>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	dri-devel@lists.freedesktop.org,
	"Mauro Carvalho Chehab" <m.chehab@samsung.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Eric Bénard" <eric@eukrea.com>,
	"Shawn Guo" <shawn.guo@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v14 09/10] ARM: dts: mbimx51sd: Add display support.
Date: Mon, 16 Jun 2014 14:29:00 +0200	[thread overview]
Message-ID: <539EE30C.4060502@eukrea.com> (raw)
In-Reply-To: <1402913484-25910-9-git-send-email-denis@eukrea.com>

On 06/16/2014 12:11 PM, Denis Carikli wrote:> +	reg_lcd_3v3: lcd-en {
 > +		compatible = "regulator-fixed";
 > +		pinctrl-names = "default";
 > +		pinctrl-0 = <&pinctrl_reg_lcd_3v3>;
 > +		regulator-name = "lcd-3v3";
 > +		regulator-min-microvolt = <3300000>;
 > +		regulator-max-microvolt = <3300000>;
 > +		gpio = <&gpio3 13 GPIO_ACTIVE_HIGH>;
 > +		regulator-boot-on;
 > +	};
 > +};
This is wrong, I'll fix it in the next serie.

What it really does is to make regulator-fixed think that the gpio is 
active low, the bindings documentation(fixed-regulator.txt) says:
 > - enable-active-high: Polarity of GPIO is Active high
 > If this property is missing, the default assumed is Active low.

Then regulator-boot-on will make it think that the regulator is already 
on and so the regulator will be disabled.
 From the bindings documentation (regulator.txt):
 > regulator-boot-on: bootloader/firmware enabled regulator

Which result at the lcd regulator being physically powered on at boot.
I didn't see that because powering it on at boot is what I want.

How can I do that beside doing it in userspace by issuing the following 
commands:
echo 4 > /sys/devices/display-subsystem/graphics/fb0/blank
echo 0 > /sys/devices/display-subsystem/graphics/fb0/blank

Denis.

WARNING: multiple messages have this Message-ID (diff)
From: Denis Carikli <denis@eukrea.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: devel@driverdev.osuosl.org,
	"Russell King" <linux@arm.linux.org.uk>,
	"Eric Bénard" <eric@eukrea.com>,
	"David Airlie" <airlied@linux.ie>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"Shawn Guo" <shawn.guo@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	"Mauro Carvalho Chehab" <m.chehab@samsung.com>
Subject: Re: [PATCH v14 09/10] ARM: dts: mbimx51sd: Add display support.
Date: Mon, 16 Jun 2014 14:29:00 +0200	[thread overview]
Message-ID: <539EE30C.4060502@eukrea.com> (raw)
In-Reply-To: <1402913484-25910-9-git-send-email-denis@eukrea.com>

On 06/16/2014 12:11 PM, Denis Carikli wrote:> +	reg_lcd_3v3: lcd-en {
 > +		compatible = "regulator-fixed";
 > +		pinctrl-names = "default";
 > +		pinctrl-0 = <&pinctrl_reg_lcd_3v3>;
 > +		regulator-name = "lcd-3v3";
 > +		regulator-min-microvolt = <3300000>;
 > +		regulator-max-microvolt = <3300000>;
 > +		gpio = <&gpio3 13 GPIO_ACTIVE_HIGH>;
 > +		regulator-boot-on;
 > +	};
 > +};
This is wrong, I'll fix it in the next serie.

What it really does is to make regulator-fixed think that the gpio is 
active low, the bindings documentation(fixed-regulator.txt) says:
 > - enable-active-high: Polarity of GPIO is Active high
 > If this property is missing, the default assumed is Active low.

Then regulator-boot-on will make it think that the regulator is already 
on and so the regulator will be disabled.
 From the bindings documentation (regulator.txt):
 > regulator-boot-on: bootloader/firmware enabled regulator

Which result at the lcd regulator being physically powered on at boot.
I didn't see that because powering it on at boot is what I want.

How can I do that beside doing it in userspace by issuing the following 
commands:
echo 4 > /sys/devices/display-subsystem/graphics/fb0/blank
echo 0 > /sys/devices/display-subsystem/graphics/fb0/blank

Denis.

  reply	other threads:[~2014-06-16 12:29 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-16 10:11 [PATCH v14 01/10] [media] v4l2: add new V4L2_PIX_FMT_RGB666 pixel format Denis Carikli
2014-06-16 10:11 ` Denis Carikli
2014-06-16 10:11 ` Denis Carikli
2014-06-16 10:11 ` [PATCH v14 02/10] imx-drm: Add RGB666 support for parallel display Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-16 10:15   ` Russell King - ARM Linux
2014-06-16 10:15     ` Russell King - ARM Linux
2014-06-16 10:15     ` Russell King - ARM Linux
2014-06-16 10:11 ` [PATCH v14 03/10] imx-drm: Correct BGR666 and the board's dts that use them Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-16 10:15   ` Russell King - ARM Linux
2014-06-16 10:15     ` Russell King - ARM Linux
2014-06-16 10:11 ` [PATCH v14 04/10] imx-drm: use defines for clock polarity settings Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-24 15:13   ` Russell King - ARM Linux
2014-06-24 15:13     ` Russell King - ARM Linux
2014-06-24 15:13     ` Russell King - ARM Linux
2014-06-24 16:25     ` Denis Carikli
2014-06-24 16:25       ` Denis Carikli
2014-06-24 16:25       ` Denis Carikli
2014-06-24 16:35       ` Russell King - ARM Linux
2014-06-24 16:35         ` Russell King - ARM Linux
2014-06-24 16:35         ` Russell King - ARM Linux
2014-06-25  4:48   ` Sascha Hauer
2014-06-25  4:48     ` Sascha Hauer
2014-06-25  4:48     ` Sascha Hauer
2014-06-25  8:43     ` Russell King - ARM Linux
2014-06-25  8:43       ` Russell King - ARM Linux
2014-06-25  8:43       ` Russell King - ARM Linux
2014-06-25  9:46       ` Sascha Hauer
2014-06-25  9:46         ` Sascha Hauer
2014-06-25  9:44     ` Denis Carikli
2014-06-25  9:44       ` Denis Carikli
2014-06-25  9:44       ` Denis Carikli
2014-06-26 20:56       ` Russell King - ARM Linux
2014-06-26 20:56         ` Russell King - ARM Linux
2014-06-27 14:17         ` [PATCH v14 updated] " Denis Carikli
2014-06-27 14:17           ` Denis Carikli
2014-06-16 10:11 ` [PATCH v14 05/10] ARM: dts: imx5*, imx6*: correct display-timings nodes Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-24 15:01   ` Russell King - ARM Linux
2014-06-24 15:01     ` Russell King - ARM Linux
2014-06-25  2:29     ` Shawn Guo
2014-06-25  2:29       ` Shawn Guo
2014-06-16 10:11 ` [PATCH v14 06/10] drm: drm_display_mode: add signal polarity flags Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-24 14:57   ` Russell King - ARM Linux
2014-06-24 14:57     ` Russell King - ARM Linux
2014-06-24 14:57     ` Russell King - ARM Linux
2014-06-24 22:13     ` Thierry Reding
2014-06-24 22:13       ` Thierry Reding
2014-06-24 22:13       ` Thierry Reding
2014-06-16 10:11 ` [PATCH v14 07/10] imx-drm: Use drm_display_mode timings flags Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-25  9:20   ` Russell King - ARM Linux
2014-06-25  9:20     ` Russell King - ARM Linux
2014-06-25  9:20     ` Russell King - ARM Linux
2014-06-16 10:11 ` [PATCH v14 08/10] drm/panel: Add Eukrea mbimxsd51 displays Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-24 15:06   ` Russell King - ARM Linux
2014-06-24 15:06     ` Russell King - ARM Linux
2014-06-24 15:06     ` Russell King - ARM Linux
2014-06-24 19:52     ` Rob Herring
2014-06-24 19:52       ` Rob Herring
2014-06-24 19:52       ` Rob Herring
2014-06-24 21:56       ` Thierry Reding
2014-06-24 21:56         ` Thierry Reding
2014-06-24 21:56         ` Thierry Reding
2014-06-25  9:42     ` Denis Carikli
2014-06-25  9:42       ` Denis Carikli
2014-06-24 21:49   ` Thierry Reding
2014-06-24 21:49     ` Thierry Reding
2014-06-24 21:49     ` Thierry Reding
2014-06-24 21:56     ` Eric Bénard
2014-06-24 21:56       ` Eric Bénard
2014-06-24 22:04       ` Thierry Reding
2014-06-24 22:04         ` Thierry Reding
2014-06-24 22:04         ` Thierry Reding
2014-06-25  8:27         ` Denis Carikli
2014-06-25  8:27           ` Denis Carikli
2014-06-16 10:11 ` [PATCH v14 09/10] ARM: dts: mbimx51sd: Add display support Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-16 12:29   ` Denis Carikli [this message]
2014-06-16 12:29     ` Denis Carikli
2014-06-16 12:29     ` Denis Carikli
2014-06-17 13:46     ` Denis Carikli
2014-06-17 13:46       ` Denis Carikli
2014-06-16 10:11 ` [PATCH v14 10/10] ARM: dts: mbimx51sd: Add CMO-QVGA backlight support Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-16 10:11   ` Denis Carikli
2014-06-16 10:14 ` [PATCH v14 01/10] [media] v4l2: add new V4L2_PIX_FMT_RGB666 pixel format Russell King - ARM Linux
2014-06-16 10:14   ` Russell King - ARM Linux
2014-06-16 10:14   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539EE30C.4060502@eukrea.com \
    --to=denis@eukrea.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.