From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Yang Z Zhang <yang.z.zhang@intel.com>,
xen-devel <xen-devel@lists.xenproject.org>,
xiantao.zhang@intel.com
Subject: Re: [PATCH 2/4] VT-d: drop redundant calls to invalidate_sync()
Date: Mon, 16 Jun 2014 14:08:58 +0100 [thread overview]
Message-ID: <539EEC6A.4070203@citrix.com> (raw)
In-Reply-To: <539F03AF020000780001AA38@mail.emea.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 2223 bytes --]
On 16/06/14 13:48, Jan Beulich wrote:
> The call tree iommu_flush_iec_index() -> __iommu_flush_iec() already
> invokes invalidate_sync(). Removing the superfluous instances at once
> allows the function to become static.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/drivers/passthrough/vtd/extern.h
> +++ b/xen/drivers/passthrough/vtd/extern.h
> @@ -48,7 +48,6 @@ int queue_invalidate_iotlb(struct iommu
> u8 granu, u8 dr, u8 dw, u16 did, u8 am, u8 ih, u64 addr);
> int queue_invalidate_iec(struct iommu *iommu,
> u8 granu, u8 im, u16 iidx);
> -int invalidate_sync(struct iommu *iommu);
> int iommu_flush_iec_global(struct iommu *iommu);
> int iommu_flush_iec_index(struct iommu *iommu, u8 im, u16 iidx);
> void clear_fault_bits(struct iommu *iommu);
> --- a/xen/drivers/passthrough/vtd/intremap.c
> +++ b/xen/drivers/passthrough/vtd/intremap.c
> @@ -358,7 +358,6 @@ static int ioapic_rte_to_remap_entry(str
> memcpy(iremap_entry, &new_ire, sizeof(struct iremap_entry));
> iommu_flush_cache_entry(iremap_entry, sizeof(struct iremap_entry));
> iommu_flush_iec_index(iommu, 0, index);
> - invalidate_sync(iommu);
>
> unmap_vtd_domain_page(iremap_entries);
> spin_unlock_irqrestore(&ir_ctrl->iremap_lock, flags);
> @@ -643,7 +642,6 @@ static int msi_msg_to_remap_entry(
> memcpy(iremap_entry, &new_ire, sizeof(struct iremap_entry));
> iommu_flush_cache_entry(iremap_entry, sizeof(struct iremap_entry));
> iommu_flush_iec_index(iommu, 0, index);
> - invalidate_sync(iommu);
>
> unmap_vtd_domain_page(iremap_entries);
> spin_unlock_irqrestore(&ir_ctrl->iremap_lock, flags);
> --- a/xen/drivers/passthrough/vtd/qinval.c
> +++ b/xen/drivers/passthrough/vtd/qinval.c
> @@ -228,7 +228,7 @@ static int queue_invalidate_wait(struct
> return ret;
> }
>
> -int invalidate_sync(struct iommu *iommu)
> +static int invalidate_sync(struct iommu *iommu)
> {
> int ret = -1;
> struct qi_ctrl *qi_ctrl = iommu_qi_ctrl(iommu);
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 3082 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-06-16 13:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 12:42 [PATCH 0/4] VT-d/qinval: miscellaneous adjustments Jan Beulich
2014-06-16 12:47 ` [PATCH 1/4] VT-d/qinval: make local variable used for communication with IOMMU "volatile" Jan Beulich
2014-06-16 12:55 ` Andrew Cooper
2014-06-16 13:03 ` Jan Beulich
2014-06-20 2:09 ` Zhang, Yang Z
2014-06-16 12:48 ` [PATCH 2/4] VT-d: drop redundant calls to invalidate_sync() Jan Beulich
2014-06-16 13:08 ` Andrew Cooper [this message]
2014-06-20 2:10 ` Zhang, Yang Z
2014-06-16 12:48 ` [PATCH 3/4] VT-d/qinval: clean up error handling Jan Beulich
2014-06-16 13:55 ` Andrew Cooper
2014-06-20 2:12 ` Zhang, Yang Z
2014-06-20 7:27 ` Jan Beulich
2014-06-20 11:30 ` Zhang, Yang Z
2014-06-16 12:49 ` [PATCH 4/4] VT-d/qinval: queue index is always unsigned Jan Beulich
2014-06-16 13:56 ` Andrew Cooper
2014-06-20 2:11 ` Zhang, Yang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539EEC6A.4070203@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
--cc=xiantao.zhang@intel.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.